Skip to content

Instantly share code, notes, and snippets.

@francylang

francylang/lang_palette_picker_submission.md

Last active December 3, 2017 03:17
Show Gist options
  • Save francylang/c1a629ff6af27a3077b310cc602a9a38 to your computer and use it in GitHub Desktop.
Save francylang/c1a629ff6af27a3077b310cc602a9a38 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
lang_palette_picker_submission.md

Palette Picker Submission Form

Project Spec

Basics

Link to the GitHub Repository for the Project

palette-picker

Link to the Deployed Application

heroku

Link to your annotated server file

annotated server file

Completion

Were you able to complete the base functionality?

Missing:Folder names must be unique (you should not be able to create two folders with the same name), annotated server.js file, testing- not fully tested, yet I ran out of time.

Yes

Which extensions, if any, did you complete?

  • User can edit the hex code in the aside palette and update to the new color.

Code Quality

Link to a specific block of your code on GitHub that you are proud of

happy code

  • I like this piece of code because I broke out the logic for the append and fetch palettes function. This eliminated nested fetch calls within the fetch projects function.

Link to a specific block of your code on GitHub that you feel not great about

sad code

  • I would like to see if there is a way to check for duplicates within the main project fetch/post instead of doing two fetch calls to projects. I am not sure how to

Attach a screenshot or paste the output from your terminal of the result of your test-suite running.

[test suite](Coming Soon)

Link to Design Inspiration

http://palettab.com/

  • I really liked the horizontal color block aside, so I used that to ground my application and build the UI from there.

Please feel free to ask any other questions or make any other statements below!

  • I've seen how done is used in testing, but I am not exactly sure where it comes from and why it some times causes my test suite to timeout.

Instructor Feedback (Instructor Name)

Specification Adherence

x points: (50 possible points)

User Interface

x points: (20 possible points)

Testing

x points: (20 possible points)

Commented Server File

x points: (10 possible points)

JavaScript Style

x points: (30 possible points)

Workflow

x points: (20 possible points)

To get a 3 on this project, you need to score 110 points or higher

To get a 4 on this project, you need to score 130 points or higher

Final Score: x / 150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment