Skip to content

Instantly share code, notes, and snippets.

@frankfaustino
Created November 19, 2018 05:55
Show Gist options
  • Save frankfaustino/d9aaeb5d3cf2355291a3ca345c431613 to your computer and use it in GitHub Desktop.
Save frankfaustino/d9aaeb5d3cf2355291a3ca345c431613 to your computer and use it in GitHub Desktop.
GitHub Pull Request Template

Description

Please include a summary of the change and a link to which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change status

  • Complete, tested, ready to review and merge
  • Complete, but not tested (may need new tests)
  • Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code has been reviewed by at least one peer
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • There are no merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment