Skip to content

Instantly share code, notes, and snippets.

@freaktechnik
Last active April 26, 2024 22:10
Show Gist options
  • Select an option

  • Save freaktechnik/4213282a354d6ff2745190ae03c7a78a to your computer and use it in GitHub Desktop.

Select an option

Save freaktechnik/4213282a354d6ff2745190ae03c7a78a to your computer and use it in GitHub Desktop.

On addons.mozilla.org Reviews

Files generated by webpack and friends are compiled files. You have to upload the source you generated your extension from to AMO for review of a listed extension. This will mean that your extension has to be reviewed by an admin-reviewer, which will result in a longer wait time in queue.

If you are ok with that trade-off there are a few measures you can take to make the review easier:

  • Don't minify the generated code (UglifyJsPlugin for webpack)
  • Don't use loaders that transform the JS output (like babel or similar)
  • Don't include third-party libraries in your file, instead directly use the original source file
  • Use a commons chunk or equivalent if possible for shared code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment