Skip to content

Instantly share code, notes, and snippets.

@galkin
Created November 9, 2016 17:59
Show Gist options
  • Save galkin/15cb1bb4975152403f8ddfdb1b26a4ec to your computer and use it in GitHub Desktop.
Save galkin/15cb1bb4975152403f8ddfdb1b26a4ec to your computer and use it in GitHub Desktop.
Kindly Care - Architecture Board Review

What well

  • Response time
  • SEO
  • Swagger as Specification for Frontend and Mobile Clients
  • Analytics
  • All features production ready

Action points

Security

  • Change config files to enviromiment variables
  • Zero-day security for wordpress. Add monitoring.
  • Amazon vendor lock can be problem in the future

Process

  • Codereview
  • Use CI
  • Contributing.md
  • Scale.md
  • Defenition of Done, Defenition of Ready, Templates for features

Code

  • remove from codebase builds and packages.
  • Different tests levels, test coverage
  • Use linting and share IDE config
  • Add shrinkwrap for repetability
  • Use tickets id in commits messages
  • Move analytics to backend

Frontend

Backend

  • Clean REST API with specification
  • Generate typescript types for clients
  • Use claster for pm2
  • Perfomance tests
  • Contract testing
  • Use workers and queue. Move to microservices

Quality Assurance

  • CI
  • Manual QA
  • Users stories

Tools

  • Change Appache to Nginx
  • elasticbeanstalk => pm2 for backend
  • Remove wordpress
  • Use CI

Database

On current data amount all is okey.

Logging

  • add request id for logging
  • add log rotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment