Which method is better?

wrapping_if.php

<?php

function myfunction(){
    if($somecondition) {
        ...
        ... //many lines of code
        ...
    } else {
        return false;
    }
}

/* OR */

function myfunction(){
    if(!$somecondition) {
        return false;
    }
    ...
    ... //many lines of code
    ...
}

I like the second one better, because it's harder to lose the if's closing bracket :)

They aren't the same, one will return false, one will not

@SeanJA how about now?

Me thinks...

<?php
//multiple returns (possibility of deleting one by accident)
function myfunction(){
    if($somecondition) {
        ...
        ... //many lines of code
        ...
        return $return;
    }
    return false;
}

/* OR */
//multiple returns (possibility of deleting one by accident)
function myfunction(){
    if(!$somecondition) {
        return false;
    }
    ...
    ... //many lines of code
    ...
    return $return;
}

// or ---
//single return point
function test(){
    $return = false;
    if($condition){
         //many lines of code
        $return = $somethingElse;
    }
    return $return;
}

The main issue was wrapping 99% of your function in an IF means there is the possibility of deleting one of the }'s by accident.

replace //many lines of code with //function_call :P

haha ya. really, if the entire function is an if statement, then the if could be put around the call.

http://stackoverflow.com/questions/36707/should-a-function-have-only-one-return-statement/36714#36714 (via @SeanJA)