Skip to content

Instantly share code, notes, and snippets.

@gazoakley

gazoakley/noma.html

Last active May 17, 2016 15:55
Show Gist options
  • Save gazoakley/1201f26d87debaf07374cbb8b1371075 to your computer and use it in GitHub Desktop.
Save gazoakley/1201f26d87debaf07374cbb8b1371075 to your computer and use it in GitHub Desktop.
Download ZIP
NOMA Code Review
Raw
noma.html
<!doctype html>
<html>
<head>
<meta charset="UTF-8">
<title>Federation | NOMA</title>
</head>
<body style="font:normal 100% 'Courier', serif;">
<?php echo "We've got ambition"; ?>
<h1>Great Creative Workspace/Multiple Buildings</h1>
<!-- 1GB wifi speeds -->
<a href="@SadlersYard">Sadler's Yard</a><br />
<a href="@ThePilcrowPub">The Pilcrow Pub</a>
<p>A community of people who care.</p>
<!-- Bring yours here too -->
<script type="text/javascript">
var $Dantzic = "";
function refurb(Federation) {
if ('underway') {
$Dantzic == "coming soon...";
}
}
</script>
<!-- #innovationdistrict @NOMA_Mcr -->
</body>
</html>
@gazoakley
Copy link
Author

gazoakley commented May 17, 2016 •
edited
Loading

Code reviewing the NOMA poster:

NOMA poster

From here: https://twitter.com/shaftag/status/732281480400019456

@gazoakley
Copy link
Author

@17:20 Unused 'Federation'

@gazoakley
Copy link
Author

@18:12 Whilst a non-empty string is truthy an actual boolean expression would be better. Also, this condition always evaluates to true, so an if block is unnecessary

@gazoakley
Copy link
Author

gazoakley commented May 17, 2016 •
edited
Loading

@19:17 It appears this should be an assignment, but the equality operator is used. JSHint will fail also fail for not using strict equality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment