Franck and me meeting Fri May 20 12:07:36 2011

gistfile1.weechatlog

09:16 -!- gnusosa_ [[email protected]] has joined #dancer-soc
09:16 [Users #dancer-soc]
09:16 [ franck] [ gnusosa_] 
09:16 -!- Irssi: #dancer-soc: Total of 2 nicks [0 ops, 0 halfops, 0 voices, 2 normal]
09:16 -!- Channel #dancer-soc created Fri May 20 12:07:36 2011
09:16 -!- Irssi: Join to #dancer-soc was synced in 14 secs
09:21 < gnusosa_> franck: ping 
09:21 < franck> gnusosa_: I'm leaving work
09:21 < franck> I'm really sorry I was not available this weekend
09:21 < franck> *really*
09:21 < gnusosa_> franck: :O How are you going to pay the bills?
09:21 < gnusosa_> :P 
09:21 < franck> :(
09:22 < gnusosa_> franck: It
09:22 < franck> I've started to pack my flat friday, and I've been doing it all the weekend
09:22 < franck> sorting papers books stuff and shits
09:22 < franck> I thought I'll be done quickly
09:22 < franck> big mistake
09:23 < gnusosa_> Done sweat it franck. Since It seem like sawyer and you were really busy I didn't stressed it, but I did do the rebase. I will commited
                  once I'm back at home. :)
09:23 < franck> ho that's great!
09:23 < franck> push and I'll review tonight
09:23 < gnusosa_> franck: I had to rework 19_dancer tests.
09:23 < franck> that's ok
09:24 < gnusosa_> franck: But if you could please send me that email you were talking about. :)
09:24 < gnusosa_> That would be great.
09:24 < franck> yeah I'll also do that
09:24 < franck> again, all my apologies
09:24 < gnusosa_> Obviously, after you take your break.
09:25 < gnusosa_> franck: Don't sweat we all have stuff to do. :)
09:25 < franck> sadly, that's true :)
09:25 < gnusosa_> yeah, not enough time for everything that is the sad part :(
09:26  * franck leaving
09:26 < gnusosa_> have a good one franck.
09:26 < gnusosa_> :)
12:30  * franck reviewing
12:32 < franck> gnusosa_: you around ?
12:34 < gnusosa_> franck: Yeah
12:34 < franck> I've pulled your branch and run the tests
12:34 < gnusosa_> But I will leave like in an hour.
12:34 < franck> there is 2 failing tests
12:34 < franck> is that normal ?
12:34 < gnusosa_> franck: refactoring/script?
12:34 < franck> yup
12:35 < gnusosa_> franck: Yeah, that is 01_script and 02_* inside of 19_dancer dir. Aren't they?
12:35 < franck> https://gist.github.com/1090431
12:35 < franck> 02 and 03 in object
12:36 < gnusosa_> franck: Ok, that is new :/
12:36 < franck> ok
12:36 < franck> do you want me to try to find the reason and comment your code, or do you want to try to find it first ?
12:37 < gnusosa_> Which ever you like :)
12:37 < franck> ok, I'll try to find and commentely                      
12:37 < franck> I'll review all this on github
12:39 < gnusosa_> great. thanks.
12:39 < gnusosa_> :)
12:39 < franck> gnusosa_: which editor are you using ?
12:39 < gnusosa_> vim
12:39 < franck> ok
12:40 < franck> there is one thing I'll also want you to do
12:40 < franck> is to configure vim to use space and not tabs
12:40 < franck> 1 tab -> 4 spaces
12:40 < franck> or else run perltidy on your codeely                      
12:40 < gnusosa_> Yeah, I want to run perltidy. :)
12:40 < franck> (we won't merge code with tabs)
12:41 < gnusosa_> franck: ok
12:41 < franck> ok, if you don't know how or want a configuration file I can help you with that)
12:41 < gnusosa_> a configuration file for perl tidy would be great.
12:41 < franck> ok
12:42 < franck> you're very lucky !
12:42 < gnusosa_> haha why? :)
12:42 < franck> there's still run_perltidy.sh inside the repo
12:42 < gnusosa_> ahh :)                                
12:42 < franck> and also .perltidyrc
12:42 < franck> so next time
12:42 < franck> before pushing code run the script
12:43 < gnusosa_> franck: If you install the Dancer::Script it does not fail.
12:43 < franck> hm
12:45 < franck> nah it's something else :)
12:46 < gnusosa_> franck: I get every test successful. :/
12:46 < gnusosa_> in object dir.
12:46 < franck> I think I know why
12:47 < franck> what's the content of line 195 in Script.pm for you ?
12:47 < franck> is it     my $add_to_manifest = sub { ?
12:50 < gnusosa_> franck: http://paste.perldancer.org/hK6NoOm0PuAc
12:50 < franck> perfect
12:50 < franck> reload
12:51 < franck> I've added a line
12:51 < franck> do you know what is this function ?
12:51 < gnusosa_> franck: To write out to MANIFEST
12:52 < franck> no the one one the line I've added :)
12:52 < gnusosa_> franck: I don't see the line.
12:52 < franck> http://paste.perldancer.org/n1HFjFkUBkfu
12:52 < franck> shit the url has changed
12:52 < franck> my bad
12:53 < gnusosa_> ahh
12:53 < gnusosa_> regexp formatting
12:53 < franck> yup
12:54 < franck> the test was failing because some paths has character which mess up the regex parser
12:54 < franck> with this, the tests passes
12:54 < gnusosa_> thanks franck.
12:54 < gnusosa_> :)
12:54 < franck> np
12:54 < franck> that's a common mistake
12:54 < franck> I've been hit by this more than once :)
12:55 < franck> ho shit
12:55 < franck> wait
12:55 < gnusosa_> more... :(
12:55 < franck> don't apply this right away
12:55 < gnusosa_> roger
12:57 < franck> https://gist.github.com/1090485
12:57 < franck> you need to copy root to a new variable while applying quotemeta
12:58 < franck> else you'll modify it and it's used later in the script
12:59 < gnusosa_> yeah, that's what I was going to tell you that I did notice root in more places.
12:59 < franck> hey, if you're doing $work stuff let me know that I won't bother you (I can do that by mail if you prefer)
12:59 < franck> +so
12:59 < gnusosa_> franck: A bit. 
12:59 < franck> ok, I'll send you an email then
13:00 < gnusosa_> No franck 
13:00 < gnusosa_> if you can email after I leave 
13:00 < gnusosa_> it helps alot when it's like this. :) 
13:00 < franck> ok :)
13:00 < gnusosa_> you can email me anything else that is left.
13:01 < gnusosa_> franck: What else did you notice? 
13:01 < franck> in your functions
13:01 < franck> you do "my $self = shift; my $bar = shift; ..."
13:02 < franck> it's better (ie more readable) to do "my ($self, $bar) = @_"
13:02 < franck> unless you *really* need to alter @_
13:02 < gnusosa_> franck: I started it that way, but sawyer suggested shift. 
13:02 < franck> ah
13:03 < franck> ok let it that way then
13:03 < gnusosa_> franck: So I followed that model. 
13:03 < franck> I'll see with him :)
13:03 < gnusosa_> franck: Sure. I stick to the scholars practices.(books) 
13:03 < gnusosa_> :P 
13:04 < gnusosa_> But, sawyer tells me this works this does not :) 
13:04 < franck> line 146/147 you do print STDERR
13:04 < franck> you should replace with "error"
13:05 < franck> we will probably need to change the layout of the debug string too since knowing how long it took to run the code is not really useful here
13:06 < franck> you can read Dancer::Logger::Abstract to see how to do it
13:07 < gnusosa_> that is docu? right? not a module? 
13:07 < franck> it's a base module for log engines
13:07 < franck> sadly that's where I put the documentation
13:07 < gnusosa_> Umm 
13:07 < franck> but yes it's the documentation that will be intersting to you
13:08 < gnusosa_> No wonder I never minded that as module.
13:08 < franck> http://metacpan.org/module/Dancer::Logger::Abstract#logger_format this part
13:09 < gnusosa_> roger
13:09 < franck> maybe a simple format like "%L> %m" could be enough
13:10 < gnusosa_> yeah simple and plain
13:10 < franck> hm weird
13:10 < franck> didn't we talked about using Dancer::Object for Dancer::Script ?
13:11 < franck> anyway we need to use it
13:11 < franck> shouldn't be hard to adapt
13:12 < franck> basically you need to s/new/init/
13:12 < franck> and add use base 'Dancer::Object'
13:13 < franck> you can also add attributes like __PACKAGE__->attributes(qw/appname/)
13:13 < franck> appname path checkversion etc
13:14 < franck> and then instead of doing $self->{appname} you could do $self->appname
13:14 < franck> it's more elegant :)
13:14 < gnusosa_> ahhh :D
13:14 < franck> so
13:14 < franck> the next big thing I want from you
13:15 < franck> is a blog post / article / mail (which ever you prefer)
13:15 < franck> explaining what can be done with 'dancer' now
13:15 < franck> and what's the improvement compared to the old script
13:16 < gnusosa_> do you want this after I finish the tasks you want me to do?
13:16 < franck> not for me, but for the other core developers so they can judge if we already merge your work in the next release
13:16 < franck> yup
13:16 < franck> I think that fixing the test / runing perltidy / moving to Dancer::Object is more important
13:17 < franck> I would like to merge your work soon
13:17 < franck> so you can enjoy the benefit of your work
13:17 < franck> and share with the community what you have done at this point
13:17 < gnusosa_> :D
13:17 < gnusosa_> Now I'm nervous
13:17 < gnusosa_> :P
13:17 < franck> haha
13:17 < franck> don't be
13:18 < franck> I'll soon leave the laptop to read
13:18 < franck> if you have any questions shoot by mail
13:18 < gnusosa_> yeah actually
13:19 < franck> if you have time to do some code, commit and push and Ill review tomorrow
13:19 < gnusosa_> I'm also leaving if you have any other tasks please email them.
13:19 < franck> sure
13:19 < gnusosa_> I will commit the test fix now. :)
13:19 < gnusosa_> do perltidy at home
13:19 < gnusosa_> and do Dancer::Object
13:19 < franck> great :)
13:19 < franck> there is a lot of code already using Dancer::Object
13:20 < franck> grep and look at existing code if you have some issues
13:20 < franck> if you can't find the answer or doubt about something -> mail
13:20 < gnusosa_> actually that's what I'm doing
13:20 < gnusosa_> right now. 
13:20 < franck> that's the best way to learn :)
13:20 < gnusosa_> looking for examples in Dancers code. 
13:20 < gnusosa_> s/Dancer/Dancer's/ 
13:22 < gnusosa_> franck: I will be leaving now. Please email me any other task or bad code you find and need some work. 
13:22 < franck> sure
13:22 < franck> have a good day 
13:22 < gnusosa_> Thank you for your time. 
13:22 < gnusosa_> You too. 
13:22 < gnusosa_> have a good read :)
13:23  * gnusosa_ leaves