goodell

Repro scripts — duplicate React keys in gloomhaven-card-browser

Supporting scripts for a fix to cmlenius/gloomhaven-card-browser.

The bug: entering a list of IDs in the Item ID box on /fh/items leaves stale cards on screen — copies of item 245 (Ancient Coin) at wrong positions, for an item that was never requested. Frosthaven item 245 is four records sharing one image path, so CardList renders four siblings with the same React key. React gathers the children it may unmount into a Map keyed by key, so the duplicates overwrite one another there and the shadowed nodes are never marked for deletion.

goodell

Process:               Lezyne-Firmware-Programmer [24973]
Path:                  /Applications/Lezyne-Firmware-Programmer.app/Contents/MacOS/Lezyne-Firmware-Programmer
Identifier:            Lezyne.GpsProgrammer
Version:               1.0 (2)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Lezyne-Firmware-Programmer [24973]
User ID:               501

Date/Time:             2017-08-04 08:56:11.527 -0500

goodell

{
    "global": {
        "check_for_updates_on_startup": true,
        "show_in_menu_bar": false,
        "show_profile_name_in_menu_bar": false
    },
    "profiles": [
        {
            "complex_modifications": {
                "rules": [

goodell

diff --git a/prov/usnic/src/usdf_cq.c b/prov/usnic/src/usdf_cq.c
index ba4cef4..a2ad994 100644
--- a/prov/usnic/src/usdf_cq.c
+++ b/prov/usnic/src/usdf_cq.c
@@ -455,8 +455,10 @@ usdf_cq_post_soft(struct usdf_cq_hard *hcq, void *context, size_t len,
         * for.
         */
        if ((entry == cq->c.soft.cq_tail) &&
-                       (cq->c.soft.cq_last_op == USDF_SOFT_CQ_WRITE))
+                       (cq->c.soft.cq_last_op == USDF_SOFT_CQ_WRITE)) {

goodell

#!/bin/zsh

# see this output:
#   $ svn diff --diff-cmd showargs sa/src/palo/include/sereno/sereno_defs.h
#   Index: sa/src/palo/include/sereno/sereno_defs.h
#   ===================================================================
#   $#=7
#   $1=|-u|
#   $2=|-L|
#   $3=|sa/src/palo/include/sereno/sereno_defs.h    (revision 258787)|

goodell

Input from: Standard input
Output to: Standard output
Output format: PCAP
Wrote packet of 8944 bytes.
Read 1 potential packet, wrote 1 packet (8984 bytes).
Capturing on 'Standard input'
Frame 1: 8944 bytes on wire (71552 bits), 8944 bytes captured (71552 bits) on interface 0
    Interface id: 0 (-)
    Encapsulation type: Ethernet (1)
    Arrival Time: Jul 14, 2015 15:46:03.000000000 PDT

goodell

define pktdump
    dump binary memory /tmp/dgoodell-pktdump.bin (char*)$arg0 (((char*)$arg0)+$arg1)
    !od -Ax -tx1 -v /tmp/dgoodell-pktdump.bin | text2pcap - - | tshark -V -x -i -
end
document pktdump
Dump a network packet in memory with tshark.
Example usage: pktdump ADDRESS LENGTH
end

goodell

- name:   fi_msg_pingpong -f usnic
  result: Pass
  time:   5.205723372
- name:   fi_msg_rma -o write -f usnic
  result: Notrun
  time:   2.189552288
  server_stdout: |
    fi_getinfo(): 393, -61 (No data available)
  client_stdout: |
    fi_getinfo(): 525, -61 (No data available)

goodell

### Keybase proof

I hereby claim:

  * I am goodell on github.
  * I am goodell (https://keybase.io/goodell) on keybase.
  * I have a public key whose fingerprint is B6DF 779C 9609 BAC3 4D66  5A2E B367 4375 0172 8814

To claim this, I am signing this object:

goodell

Open MPI Git Best Practices

For a nice, relatively brief overview of Git's basic usage, please see the Pro Git book by Scott Chacon, available for free online. If you want to understand the nitty-gritty, check out Git From the Bottom Up.

Otherwise, here are a list of typical "dos" and "don'ts" for Git, some with a specific eye towards Open MPI:

Do

• make smaller, logically self-contained commits