Skip to content

Instantly share code, notes, and snippets.

@grokys
Created August 6, 2016 04:50
Show Gist options
  • Select an option

  • Save grokys/e4a50494142938dfed7b94821496c5af to your computer and use it in GitHub Desktop.

Select an option

Save grokys/e4a50494142938dfed7b94821496c5af to your computer and use it in GitHub Desktop.
# Flow for Maintainer Workflow
- In PR list, each open PR has a "checkout" button if no local branch
- If a local branch for a PR it instead has "merge" and "sync" icon buttons
- Clicking "checkout" checks out PR as local branch and switches to that branch
- "Sync" refreshes from upstream PR
- "Merge" merges the PR to master and switches to master
- Once synced, a "Delete" button appears - this deletes the local and remote branch
(if PR from same repos)
# Questions
- How do we name local PR branches? Like in Desktop ("pr/123"), or could we name it more
intelligent (e.g. "pr/123-this-does-that)?
- Would a user making changes on a PR branch cause problems? e.g. with subsequent sync?
- Can we always tell if a branch is the PR branch we're looking for? What if the user has
already checked out the PR in desktop or with command-line? Do we reuse those?
- Should "delete" button always be present on local PR to delete local branch? Would the
difference in behavior be confusing? i.e. that sometimes it just deletes local and
sometimes both local and remote.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment