harish2704/lodash.get.js

devmuffy · 2017-04-10T15:21:30Z

Function getProp contains error. Look at the example below:

function getProp( object, keys, defaultVal ){
  keys = Array.isArray( keys )? keys : keys.split('.');
  object = object[keys[0]];
  if( object && keys.length>1 ){
    return getProp( object, keys.slice(1));
  }
  return object === undefined? defaultVal : object;
}

console.log(getProp({}, 'x', 'DEFAULT_VAL')); // => 'DEFAULT_VAL'
console.log(getProp({}, 'x.x', 'DEFAULT_VAL')); // => 'DEFAULT_VAL'
console.log(getProp({x: {}}, 'x.x', 'DEFAULT_VAL')); // => undefined

You don't pass down defaultVal to recursive call. Fixed version:

function getProp( object, keys, defaultVal ){
  keys = Array.isArray( keys )? keys : keys.split('.');
  object = object[keys[0]];
  if( object && keys.length>1 ){
    return getProp( object, keys.slice(1), defaultVal );
  }
  return object === undefined? defaultVal : object;
}

console.log(getProp({}, 'x', 'DEFAULT_VAL')); // => 'DEFAULT_VAL'
console.log(getProp({}, 'x.x', 'DEFAULT_VAL')); // => 'DEFAULT_VAL'
console.log(getProp({x: {}}, 'x.x', 'DEFAULT_VAL')); // => 'DEFAULT_VAL'

manjunatha-d · 2017-04-14T10:10:18Z

I guess return object ? object : defaultVal is more cleaner than return object === undefined? defaultVal : object;

devmuffy · 2017-04-14T14:10:22Z

It is clearer but those aren't the same statements.

// I'm also comparing _.get here
function getProp(object, keys, defaultVal) {
    keys = Array.isArray(keys) ? keys : keys.split('.');
    object = object[keys[0]];
    if (object && keys.length > 1) {
        return getProp(object, keys.slice(1), defaultVal);
    }
    return object === undefined ? defaultVal : object;
}

function getPropClearer(object, keys, defaultVal) {
    keys = Array.isArray(keys) ? keys : keys.split('.');
    object = object[keys[0]];
    if (object && keys.length > 1) {
        return getPropClearer(object, keys.slice(1), defaultVal);
    }
    return object ? object : defaultVal;
}

var testEmptyString = { x: '' }
console.log(
    getProp(testEmptyString, 'x', 'DEFAULT_VAL'), // => ''
    _.get(testEmptyString, 'x', 'DEFAULT_VAL'), // => ''
    getPropClearer(testEmptyString, 'x', 'DEFAULT_VAL') // => 'DEFAULT_VAL'
)

var testNull = { x: null }
console.log(
    getProp(testNull, 'x', 'DEFAULT_VAL'), // => null
    _.get(testNull, 'x', 'DEFAULT_VAL'), // => null
    getPropClearer(testNull, 'x', 'DEFAULT_VAL') // => 'DEFAULT_VAL'
)

var testNestedFalse = { x: { y: false } }
console.log(
    getProp(testNestedFalse, 'x.y', 'DEFAULT_VAL'), // => false
    _.get(testNestedFalse, 'x.y', 'DEFAULT_VAL'), // => false
    getPropClearer(testNestedFalse, 'x.y', 'DEFAULT_VAL') // => 'DEFAULT_VAL'
)

Here you can find pretty nice explanation what's going on.

wingliu0 · 2017-12-14T10:46:43Z

This version can also support array syntax
Like a[0].b.c

__get(object, keys, defaultVal = null): any {
    keys = Array.isArray(keys) ? keys : keys.replace(/(\[(\d)\])/g, '.$2').split('.');
    object = object[keys[0]];
    if (object && keys.length > 1) {
      return this.__get(object, keys.slice(1), defaultVal);
    }
    return object === undefined ? defaultVal : object;
  }

pi0 · 2018-02-01T23:21:30Z

This version is slightly optimized and also supports root selectors (getProp({ foo: 'bar'}, '' => { foo:bar } ):

/**
 * getProp utility - an alternative to lodash.get
 * @author @harish2704, @muffypl, @pi0
 * @param {Object} object
 * @param {String|Array} path
 * @param {*} defaultVal
 */
function getProp (object, path, defaultVal) {
  const _path = Array.isArray(path)
    ? path
    : path.split('.').filter(i => i.length)

  if (!_path.length) {
    return object === undefined ? defaultVal : object
  }

  return getProp(object[_path.shift()], _path, defaultVal)
}

imnnquy · 2019-01-15T09:47:39Z

The above version has an issue when object is undefined and _path length > 0, an improvement here:

/**
 * getProp utility - an alternative to lodash.get
 * @author @harish2704, @muffypl, @pi0, @imnnquy
 * @param {Object} object
 * @param {String|Array} path
 * @param {*} defaultVal
 */
function getProp (object, path, defaultVal) {
  const _path = Array.isArray(path)
    ? path
    : path.split('.').filter(i => i.length)

  if (!_path.length) {
    return object === undefined ? defaultVal : object
  }

  return getProp(object[_path.shift()], _path, defaultVal)
}

itneste · 2019-07-01T06:18:00Z

that's will be better.

 function getProp (object, path, defaultVal) {
    const PATH = Array.isArray(path)
      ? path
      : path.split('.').filter(i => i.length);
    if (!PATH.length) {
      return object === undefined ? defaultVal : object;
    }
    if (object === null || object === undefined || typeof (object[PATH[0]]) === 'undefined') {
      return defaultVal;
    }
    return getProp(object[PATH.shift()], PATH, defaultVal);
}

wcdbmv · 2019-09-03T21:47:43Z

that's will be better

/**
 * Gets the value at `path` of `object`.
 * @param {Object} object
 * @param {string|Array} path
 * @returns {*} value if exists else undefined
 */
const get = (object, path) => {
	if (typeof path === "string") path = path.split(".").filter(key => key.length);
	return path.reduce((dive, key) => dive && dive[key], object);
};

alexbruno · 2019-10-08T02:40:38Z

The above version doesn't support some formats supported by lodash.get.

Like: get(obj, ['forecast', 0, 'main.temp'], null)

But this version do it:

function get (object, path, value) {
  const pathArray = Array.isArray(path) ? path : path.split('.').filter(key => key)
  const pathArrayFlat = pathArray.flatMap(part => typeof part === 'string' ? part.split('.') : part)

  return pathArrayFlat.reduce((obj, key) => obj && obj[key], object) || value
}

Sooro1024 · 2020-01-22T07:38:37Z

The above version don't support some formats supported by lodash.get.

Like: get(obj, ['forecast', 0, 'main.temp'], null)

But this version do it:

function get (object, path, value) {
  const pathArray = Array.isArray(path) ? path : path.split('.').filter(key => key)
  const pathArrayFlat = pathArray.flatMap(part => typeof part === 'string' ? part.split('.') : part)

  return pathArrayFlat.reduce((obj, key) => obj && obj[key], object) || value
}

If return value is falsy it will not play properly.

function get (object, path, value) {
  const pathArray = Array.isArray(path) ? path : path.split('.').filter(key => key);
  const pathArrayFlat = pathArray.flatMap(part => typeof part === 'string' ? part.split('.') : part);
  const checkValue = pathArrayFlat.reduce((obj, key) => obj && obj[key], object);
  return  checkValue === undefined ? value : checkValue
}

alexbruno · 2020-01-22T18:16:13Z

Sorry @Sooro1024, but I don't think it's necessary!
Did you notice the || in my return?

return pathArrayFlat.reduce((obj, key) => obj && obj[key], object) || value

If the reduce result is falsy (undefined inclusive), the value is returned.

So, if the expected return is a number, just pass a value = 0. And if a boolean is expected, just pass a value = false.

So, I think extra code is not necessary. Just take some Node or DevTools console test:

And here is a use test:

Sooro1024 · 2020-01-28T16:46:11Z

I used this in react, in a table component and for me, it was necessary that if the value is falsy show the provided default value. That is the reason I prefer to check with `===` for me, it is a more safe and common solution. But I am very grateful to you. For this function

…

On Wed, Jan 22, 2020 at 10:16 PM Alex Bruno Cáceres < ***@***.***> wrote: Sorry @Sooro1024 <https://github.com/Sooro1024>, but I don't think it's necessary! Did you notice the || in my return? return pathArrayFlat.reduce((obj, key) => obj && obj[key], object) || value If the reduce result is falsy (undefined inclusive), the value is returned. So, if the expected return is a number, just pass a value = 0. And if a boolean is expected, just pass a value = false. So, I think extra code is not necessary. Just take some Node or DevTools console test: [image: js] <https://user-images.githubusercontent.com/2638399/72920615-8d3d6100-3d41-11ea-8f00-efeac20d9938.png> And here is a use test: [image: get] <https://user-images.githubusercontent.com/2638399/72921345-0093a280-3d43-11ea-85f1-99707ed51241.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://gist.github.com/d0ee530e6ee75bad6fd30c98e5ad9dab?email_source=notifications&email_token=ALJC4N5LING2JDBVFLQPRJ3Q7CEO5A5CNFSM4H4PA6VKYY3PNVWWK3TUL52HS4DFVNDWS43UINXW23LFNZ2KUY3PNVWWK3TUL5UWJTQAGAHG6#gistcomment-3149423>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALJC4N6OXV5X2USYZCL7AXDQ7CEO5ANCNFSM4H4PA6VA> .

souljorje · 2021-11-23T15:10:48Z

@pi0, you solution throws an error, but thanks for inspiration for the most performant solution from provided here.

const getPropByPath = (object, path, defaultValue) => {
    const _path = Array.isArray(path)
        ? path
        : path.split('.');
    if (object && _path.length) return getPropByPath(object[_path.shift()], _path, defaultValue);
    return object === undefined ? defaultValue : object;
};

// without default value
const getPropByPath = (object, path) => {
    const _path = Array.isArray(path)
        ? path
        : path.split('.');
    if (object && _path.length) return getPropByPath(object[_path.shift()], _path);
    return object;
};

Benchmarks: https://jsbench.me/ogkwc7fxlg/1. I didn't include implementations out of scope of original lodash.get and those which iterate over whole path without break - i.e. reduce-based - they're too slow.

specimen151 · 2021-11-24T15:27:09Z

@pi0, you solution throws an error, but thanks for inspiration for the most performant solution from provided here.

const getPropByPath = (object, path, defaultValue) => {
    const _path = Array.isArray(path)
        ? path
        : path.split('.');
    if (object && _path.length) return getPropByPath(object[_path.shift()], _path, defaultValue);
    return object === undefined ? defaultValue : object;
};

// without default value
const getPropByPath = (object, path) => {
    const _path = Array.isArray(path)
        ? path
        : path.split('.');
    if (object && _path.length) return getPropByPath(object[_path.shift()], _path);
    return object;
};

Benchmarks: https://jsbench.me/ogkwc7fxlg/1. I didn't include implementations out of scope of original lodash.get and those which iterate over whole path without break - i.e. reduce-based - they're too slow.

This solution fixed for me a problem: Empty string counts as undefined.
I'd like the empty string back. It's not the same (for me).

I'm talking about the version without default value.

romanown · 2022-03-27T20:12:44Z

setProp is not work.

andrewchilds · 2022-04-28T01:01:56Z

I created a fork of this version that includes tests, handles falsey values (including undefined), and handles objects-inside-arrays (i.e. '[0].id') as well as arrays-inside-objects (i.e. 'a.b[0].c'):

https://gist.github.com/andrewchilds/30a7fb18981d413260c7a36428ed13da

romanown · 2022-04-28T21:58:39Z

many thanks

	/* Implementation of lodash.get function */
	function getProp( object, keys, defaultVal ){
	keys = Array.isArray( keys )? keys : keys.split('.');
	object = object[keys[0]];
	if( object && keys.length>1 ){
	return getProp( object, keys.slice(1) );
	}
	return object === undefined? defaultVal : object;
	}

	/* Implementation of lodash.set function */
	function setProp( object, keys, val ){
	keys = Array.isArray( keys )? keys : keys.split('.');
	if( keys.length>1 ){
	object[keys[0]] = object[keys[0]] \|\| {};
	return setProp( object[keys[0]], keys.slice(1), val );
	}
	object[keys[0]] = val;
	}

harish2704/lodash.get.js

devmuffy commented Apr 10, 2017

manjunatha-d commented Apr 14, 2017

devmuffy commented Apr 14, 2017

wingliu0 commented Dec 14, 2017

pi0 commented Feb 1, 2018

imnnquy commented Jan 15, 2019 •

edited

Loading

itneste commented Jul 1, 2019 •

edited

Loading

wcdbmv commented Sep 3, 2019 •

edited

Loading

alexbruno commented Oct 8, 2019 •

edited

Loading

Sooro1024 commented Jan 22, 2020 •

edited

Loading

alexbruno commented Jan 22, 2020

Sooro1024 commented Jan 28, 2020 via email •

edited

Loading

souljorje commented Nov 23, 2021 •

edited

Loading

specimen151 commented Nov 24, 2021

romanown commented Mar 27, 2022

andrewchilds commented Apr 28, 2022

romanown commented Apr 28, 2022

harish2704/lodash.get.js

devmuffy commented Apr 10, 2017

manjunatha-d commented Apr 14, 2017

devmuffy commented Apr 14, 2017

wingliu0 commented Dec 14, 2017

pi0 commented Feb 1, 2018

imnnquy commented Jan 15, 2019 • edited Loading

itneste commented Jul 1, 2019 • edited Loading

wcdbmv commented Sep 3, 2019 • edited Loading

alexbruno commented Oct 8, 2019 • edited Loading

Sooro1024 commented Jan 22, 2020 • edited Loading

alexbruno commented Jan 22, 2020

Sooro1024 commented Jan 28, 2020 via email • edited Loading

souljorje commented Nov 23, 2021 • edited Loading

specimen151 commented Nov 24, 2021

romanown commented Mar 27, 2022

andrewchilds commented Apr 28, 2022

romanown commented Apr 28, 2022

imnnquy commented Jan 15, 2019 •

edited

Loading

itneste commented Jul 1, 2019 •

edited

Loading

wcdbmv commented Sep 3, 2019 •

edited

Loading

alexbruno commented Oct 8, 2019 •

edited

Loading

Sooro1024 commented Jan 22, 2020 •

edited

Loading

Sooro1024 commented Jan 28, 2020 via email •

edited

Loading

souljorje commented Nov 23, 2021 •

edited

Loading