Helmut Januschka hjanuschka

How to Fix BrowserJS Abort Issue - V8 Termination Needs Yield Points

Summary

Good news: CL 7110745 is working correctly (all 31 bots passed). The issue is that V8's TerminateExecution() can only interrupt JavaScript at yield points, and the current sitegeist wrapper doesn't create them.

The Problem

When you call chrome.userScripts.terminate(), it invokes v8::Isolate::TerminateExecution(). However, this only works when JavaScript yields control back to the event loop.

Tested with: Xcode 15.4 (SDK 14.5)

Apply

cd /path/to/chromium/src
git apply 1.patch
autoninja -C out/Default chrome

chrome.userScripts.execute() with Cancellation Support

New API Overview

The chrome.userScripts.execute() now supports script cancellation through execution IDs:

1. Execute with optional executionId (handle pattern)

const results = await chrome.userScripts.execute({
 js: [{ code: wrapperCode }],

Setup testing environment

ClassicPress

bin/install-cp-tests.sh  DBNAME DBUSER DBPASS DBIP:DBPORT master false

master == the version

	#include "skia.h"

	#include <stdexcept>
	#include <wrl/client.h>
	#include <dwrite.h>


	Skia::Skia() {
	mgr = SkFontMgr_New_DirectWrite(); // Platform-specific for Windows
	}


	# BLACKFIRE.io setup
	RUN version=$(php -r "echo PHP_MAJOR_VERSION.PHP_MINOR_VERSION;") \
	&& wget -O /tmp/blackfire-probe.tar.gz https://blackfire.io/api/v1/releases/probe/php/linux/amd64/$version \
	&& tar zxpf /tmp/blackfire-probe.tar.gz -C /tmp \
	&& mv /tmp/blackfire-*.so $(php -r "echo ini_get('extension_dir');")/blackfire.so \
	&& printf "extension=blackfire.so\nblackfire.agent_socket=tcp://blackfire:8707\n" > $PHP_INI_DIR/conf.d/blackfire.ini

	<?php
	namespace Test;

	class PrettyPrinter extends \PHPUnit\TextUI\ResultPrinter implements \PHPUnit\Framework\TestListener
	{
	private $headerPrinted = false;
	/**
	* Function name is slightly deceiving because it is called at the beginning of the
	* unit test summary (after all tests have run)
	*/

	/******/ (function(modules) { // webpackBootstrap
	/******/ // The module cache
	/******/ var installedModules = {};
	/******/
	/******/ // The require function
	/******/ function __webpack_require__(moduleId) {
	/******/
	/******/ // Check if module is in cache
	/******/ if(installedModules[moduleId]) {
	/******/ return installedModules[moduleId].exports;

	<?php

	acf_add_local_field_group(array(
	'key' => 'group_5878908956b61',
	'title' => __('Media: Copyright', 'kmm-media'),
	'fields' => array(
	array(
	'key' => 'field_587890c1ce938',
	'label' => __('Copyright', 'kmm-media'),
	'name' => 'copyright',

	array (
	'key' => 'field_585149317aa44',
	'label' => 'Fixposition',
	'name' => 'ressort_template_position',
	'type' => 'ressort_picker',
	'instructions' => '',
	'required' => 0,
	'conditional_logic' => 0,
	'wrapper' => array (
	'width' => '10%',