Skip to content

Instantly share code, notes, and snippets.

@holmesal

holmesal/pre-pr-checklist.md

Last active April 7, 2017 21:03
Show Gist options
  • Save holmesal/ce285ba4e52afba966a3dc355b542541 to your computer and use it in GitHub Desktop.
Save holmesal/ce285ba4e52afba966a3dc355b542541 to your computer and use it in GitHub Desktop.
Download ZIP
Pre-PR Checklist
Raw
pre-pr-checklist.md

Pre-PR checklist

Did you add any Typographic components?

If so, come up with a witty name and add the type parameters to the Trello card.

Are you using any icons that don't already exist in /styleguide/icons?

If so, add the SVGs to that folder. Make sure you add both 12 and 24px sizes.

Are all icons PinkBoxed in the mockups?

If not, PinkBox them! This makes layout much easier.

Are the exports the correct number of columns wide?

  • Screen or SuperView: 26 columns wide
  • Component: tightly-cropped

Are there any mockups in /styleguide/mockups that can be deleted?

If so, do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment