Skip to content

Instantly share code, notes, and snippets.

@hotsphink
Created October 20, 2025 19:35
Show Gist options
  • Select an option

  • Save hotsphink/0e0081abdf3cbb194525e6507937e4da to your computer and use it in GitHub Desktop.

Select an option

Save hotsphink/0e0081abdf3cbb194525e6507937e4da to your computer and use it in GitHub Desktop.
Additions to enable js static lib to link
diff --git a/toolkit/components/glean/bindings/private/Denominator.h b/toolkit/components/glean/bindings/private/Denominator.h
index 882a46b709..f990f4d41c 100644
--- a/toolkit/components/glean/bindings/private/Denominator.h
+++ b/toolkit/components/glean/bindings/private/Denominator.h
@@ -16,6 +16,8 @@
# include "nsString.h"
#endif // MOZILLA_INTERNAL_API
+#include "mozilla/Types.h"
+
namespace mozilla::glean {
namespace impl {
@@ -29,7 +31,7 @@
*
* @param aAmount The amount to increase by. Should be positive.
*/
- void Add(int32_t aAmount = 1) const;
+ MFBT_API void Add(int32_t aAmount = 1) const;
#ifdef MOZILLA_INTERNAL_API
/**
diff --git a/toolkit/components/glean/bindings/private/Numerator.h b/toolkit/components/glean/bindings/private/Numerator.h
index cf81e26ac9..ab8ab586cb 100644
--- a/toolkit/components/glean/bindings/private/Numerator.h
+++ b/toolkit/components/glean/bindings/private/Numerator.h
@@ -16,6 +16,8 @@
# include "nsString.h"
#endif // MOZILLA_INTERNAL_API
+#include "mozilla/Types.h"
+
namespace mozilla::dom {
struct GleanRateData;
} // namespace mozilla::dom
@@ -35,7 +37,7 @@
*
* @param aAmount The amount to increase by. Should be positive.
*/
- void AddToNumerator(int32_t aAmount = 1) const;
+ MFBT_API void AddToNumerator(int32_t aAmount = 1) const;
#ifdef MOZILLA_INTERNAL_API
/**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment