Last active
February 27, 2017 20:35
-
-
Save icambridge/afc7bad7c569b83c8df993582f7f72f6 to your computer and use it in GitHub Desktop.
Code Review Template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### SOLID | |
[ ] Single Responsiblity Principle | |
[ ] Open/Closed Principle | |
[ ] Liskov's object replacement Principle | |
[ ] Interface Segegration Principle | |
[ ] Dependency Inversion Principle | |
### Bugs | |
[ ] Too strict type checking on errors | |
[ ] Too loose type checking on errors | |
[ ] Returning non objects and objects in the same method | |
### Code Design | |
[ ] Boolean returning methods not named with `is`,`has`,`does` | |
[ ] Interfacing implementation details | |
[ ] Not interfacing core business logic | |
[ ] Entity logic in entity. (Not returning state to do logic outside of entity) | |
[ ] Law of Demeter | |
[ ] Assignments in clauses | |
[ ] Tell, don't ask | |
[ ] Adapter pattern should be used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment