REFACTORING.md

Before rafactoring, clean the code base

1. Use Git
2. Choose your style guide and use linters
3. Create graph and clean dead code
4. Determinate code duplication, use patterns

Git

Using git saves time to find a bug, by code author or feature

Code duplication

npx jsinspect --ignore "node_modules|jsx" src > jsinspect.out

NOTE: Has issues with some jsx features: danielstjules/jsinspect#87

• Detect and Refactor JavaScript Copy-Paste Code
• Don't Copy Code. Oh, and Inheritance and Composition are Bad, Too

Code smells

Categories of code smells

• bloaters

  • long method
  • large class
  • data clumps
  • long param list
  • primitive obsession

• toold abusers

  • switch statements
  • refused bequest
  • alt classes with diff interfaces
  • temp field

• change preventers

  • divergent change
  • shotgun surgery
  • parallel inheritance hierarchies

• dispensables

  • lazy class
  • speculative genratlity
  • data class
  • duplicated code

• dispensables

  • feature envy
  • inappropriate intimacy
  • message chains - law of demeter violations
  • middle man - solely exists to fwd messages to others

• RailsConf 2016 - Get a Whiff of This by Sandi Metz

• Code Smells on Refactoring.guru

• List of code smells on Reek documentation