Skip to content

Instantly share code, notes, and snippets.

@invisiblek
Created April 13, 2015 01:04
Show Gist options
  • Save invisiblek/90f7f5b3df42542cac99 to your computer and use it in GitHub Desktop.
Save invisiblek/90f7f5b3df42542cac99 to your computer and use it in GitHub Desktop.
diff --git a/src/java/com/android/internal/telephony/UiccSmsController.java b/src/java/com/android/internal/telephony/UiccSmsController.java
old mode 100755
new mode 100644
diff --git a/src/java/com/android/internal/telephony/dataconnection/DcTracker.java b/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
index 83af92a..05b3557 100755
--- a/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
+++ b/src/java/com/android/internal/telephony/dataconnection/DcTracker.java
@@ -904,7 +904,6 @@ public final class DcTracker extends DcTrackerBase {
}
private boolean trySetupData(ApnContext apnContext) {
- boolean retValue = false;
if (DBG) {
log("trySetupData for type:" + apnContext.getApnType() +
" due to " + apnContext.getReason() + " apnContext=" + apnContext);
@@ -947,13 +946,10 @@ public final class DcTracker extends DcTrackerBase {
ArrayList<ApnSetting> waitingApns = buildWaitingApns(apnContext.getApnType(),
radioTech);
if (waitingApns.isEmpty()) {
+ notifyNoData(DcFailCause.MISSING_UNKNOWN_APN, apnContext);
notifyOffApnsOfAvailability(apnContext.getReason());
- retValue = setupData(apnContext, radioTech);
- if(!retValue) {
- notifyNoData(DcFailCause.MISSING_UNKNOWN_APN, apnContext);
- }
- notifyOffApnsOfAvailability(apnContext.getReason());
- return retValue;
+ if (DBG) log("trySetupData: X No APN found retValue=false");
+ return false;
} else {
apnContext.setWaitingApns(waitingApns);
if (DBG) {
@@ -972,9 +968,7 @@ public final class DcTracker extends DcTrackerBase {
+ apnListToString(apnContext.getWaitingApns()));
}
}
-
- retValue = setupData(apnContext, radioTech);
-
+ boolean retValue = setupData(apnContext, radioTech);
notifyOffApnsOfAvailability(apnContext.getReason());
if (DBG) log("trySetupData: X retValue=" + retValue);
@@ -1380,38 +1374,8 @@ public final class DcTracker extends DcTrackerBase {
apnSetting = apnContext.getNextWaitingApn();
if (apnSetting == null) {
- if(PhoneConstants.PHONE_TYPE_CDMA==mPhone.getPhoneType()) {
- String[] mDunApnTypes = { PhoneConstants.APN_TYPE_DUN };
- final int mDefaultApnId = DctConstants.APN_DEFAULT_ID;
- final String[] mDefaultApnTypes = {
- PhoneConstants.APN_TYPE_DEFAULT,
- PhoneConstants.APN_TYPE_MMS,
- PhoneConstants.APN_TYPE_SUPL,
- PhoneConstants.APN_TYPE_HIPRI,
- PhoneConstants.APN_TYPE_FOTA,
- PhoneConstants.APN_TYPE_IMS,
- PhoneConstants.APN_TYPE_CBS};
-
-
- String[] types;
- int apnId;
- if (mRequestedApnType.equals(PhoneConstants.APN_TYPE_DUN)) {
- types = mDunApnTypes;
- apnId = DctConstants.APN_DUN_ID;
- } else {
- types = mDefaultApnTypes;
- apnId = mDefaultApnId;
- }
- apnSetting = new ApnSetting(apnId, getOperatorNumeric(), null, null,
- null, null, null, null, null, null, null,
- RILConstants.SETUP_DATA_AUTH_PAP_CHAP, types,
- PROPERTY_CDMA_IPPROTOCOL, PROPERTY_CDMA_ROAMING_IPPROTOCOL, true, 0,
- 0, false, 0, 0, 0, PhoneConstants.UNSET_MTU, "", "");
- if (DBG) log("setupData: CDMA detected and apnSetting == null, use stubbed CDMA APN setting= " + apnSetting);
- } else {
- if (DBG) log("setupData: return for no apn found!");
- return false;
- }
+ if (DBG) log("setupData: return for no apn found!");
+ return false;
}
int profileId = apnSetting.profileId;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment