Skip to content

Instantly share code, notes, and snippets.

@invisiblek
Created January 24, 2017 21:33
Show Gist options
  • Save invisiblek/da101dafc272cd81f7656e6de960b376 to your computer and use it in GitHub Desktop.
Save invisiblek/da101dafc272cd81f7656e6de960b376 to your computer and use it in GitHub Desktop.
diff --git a/build/tasks/dt_image.mk b/build/tasks/dt_image.mk
index 0f84946..c8ccc67 100644
--- a/build/tasks/dt_image.mk
+++ b/build/tasks/dt_image.mk
@@ -2,7 +2,7 @@
# Generate device tree image (dt.img)
#----------------------------------------------------------------------
ifeq ($(strip $(BOARD_CUSTOM_BOOTIMG_MK)),)
-ifeq ($(strip $(BOARD_KERNEL_SEPARATED_DT)),true)
+ifeq (,$(findstring -dtb,$(BOARD_KERNEL_IMAGE_NAME)))
ifneq ($(strip $(BOARD_KERNEL_PREBUILT_DT)),true)
ifeq ($(strip $(BUILD_TINY_ANDROID)),true)
include device/qcom/common/dtbtool/Android.mk
diff --git a/build/tasks/kernel.mk b/build/tasks/kernel.mk
index 21c9356..02f718a 100644
--- a/build/tasks/kernel.mk
+++ b/build/tasks/kernel.mk
@@ -30,17 +30,15 @@
# TARGET_KERNEL_ARCH = Kernel Arch
# TARGET_KERNEL_HEADER_ARCH = Optional Arch for kernel headers if
# different from TARGET_KERNEL_ARCH
-# TARGET_USES_UNCOMPRESSED_KERNEL = 'true' if Kernel is uncompressed,
-# optional, defaults to false
# TARGET_KERNEL_CROSS_COMPILE_PREFIX = Compiler prefix (e.g. arm-eabi-)
# defaults to arm-linux-androidkernel- for arm
# aarch64-linux-androidkernel- for arm64
# x86_64-linux-androidkernel- for x86
#
-# BOARD_KERNEL_IMAGE_NAME = Built image name, optional,
-# defaults to Image.gz on arm64
-# defaults to Image if TARGET_USES_UNCOMPRESSED_KERNEL
-# defaults to zImage otherwise
+# BOARD_KERNEL_IMAGE_NAME = Built image name
+# for arm: zImage or zImage-dtb
+# for arm64: Image.gz or Image.gz-dtb
+# for uncompressed: Image or Image-dtb
#
# KERNEL_TOOLCHAIN_PREFIX = Overrides TARGET_KERNEL_CROSS_COMPILE_PREFIX,
# Set this var in shell to override
@@ -96,25 +94,10 @@ ifeq ($(KERNEL_HEADER_DEFCONFIG),)
KERNEL_HEADER_DEFCONFIG := $(KERNEL_DEFCONFIG)
endif
-
-ifneq ($(BOARD_KERNEL_IMAGE_NAME),)
- TARGET_PREBUILT_INT_KERNEL_TYPE := $(BOARD_KERNEL_IMAGE_NAME)
-else
- ifeq ($(TARGET_USES_UNCOMPRESSED_KERNEL),true)
- TARGET_PREBUILT_INT_KERNEL_TYPE := Image
- else
- ifeq ($(KERNEL_ARCH),arm64)
- TARGET_PREBUILT_INT_KERNEL_TYPE := Image.gz
- else
- TARGET_PREBUILT_INT_KERNEL_TYPE := zImage
- endif
- endif
- ifeq ($(TARGET_KERNEL_APPEND_DTB),true)
- TARGET_PREBUILT_INT_KERNEL_TYPE := $(TARGET_PREBUILT_INT_KERNEL_TYPE)-dtb
- endif
+ifeq ($(BOARD_KERNEL_IMAGE_NAME),)
+$(error BOARD_KERNEL_IMAGE_NAME not defined.)
endif
-
-TARGET_PREBUILT_INT_KERNEL := $(KERNEL_OUT)/arch/$(KERNEL_ARCH)/boot/$(TARGET_PREBUILT_INT_KERNEL_TYPE)
+TARGET_PREBUILT_INT_KERNEL := $(KERNEL_OUT)/arch/$(KERNEL_ARCH)/boot/$(BOARD_KERNEL_IMAGE_NAME)
# Clear this first to prevent accidental poisoning from env
MAKE_FLAGS :=
@@ -296,7 +279,7 @@ $(KERNEL_CONFIG): $(KERNEL_OUT_STAMP) $(KERNEL_DEFCONFIG_SRC) $(KERNEL_ADDITIONA
TARGET_KERNEL_BINARIES: $(KERNEL_OUT_STAMP) $(KERNEL_CONFIG) $(KERNEL_HEADERS_INSTALL_STAMP)
@echo "Building Kernel"
- $(MAKE) $(MAKE_FLAGS) -C $(KERNEL_SRC) O=$(KERNEL_OUT) ARCH=$(KERNEL_ARCH) $(KERNEL_CROSS_COMPILE) $(TARGET_PREBUILT_INT_KERNEL_TYPE)
+ $(MAKE) $(MAKE_FLAGS) -C $(KERNEL_SRC) O=$(KERNEL_OUT) ARCH=$(KERNEL_ARCH) $(KERNEL_CROSS_COMPILE) $(BOARD_KERNEL_IMAGE_NAME)
$(hide) if grep -q 'CONFIG_OF=y' $(KERNEL_CONFIG) ; \
then \
echo "Building DTBs" ; \
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment