When example

gallery when.js

{
   get_next: function(on_success, on_error, offset) { // Need to support on_success and on_error for legacy
      var deferred = when.defer();
      deferred.then(on_success, on_error);
      
      if (this.can_get_data()) {
        this.get_data({
          offset: offset
        }).then(function(e) { // Is this how I go about chaining promises ?
          deferred.resolve(e);
        }, function(e) {
          deferred.reject(e);
        });
      } else {
        deferred.reject("Not allowed to get data");
      }
      
      return deferred.promise;
    },
    get_data: function(overrides) {
      var self = this;
      var deferred = when.defer();
      
      var data_source_name = this.get_data_source_name();
      
      if (data_source_name && typeof data_source_name === 'string') {
        if (typeof this.kawr[data_source_name] == "function") {
          var params = this.get_data_source_parameters(overrides);
          
          if (params && typeof params === 'object') {
            
            this.pending_items = true;

            // this function returns a promise am I chaining it correctly ?
            this.kawr[data_source_name](params).then(
              function(e) {
                self.pending_items = false;
                deferred.resolve(e);
              }, function (e) {
                self.pending_items = false;
                deferred.reject(e);
              }
            );
          } else {
            deferred.reject("No parameters we returned");
          }
        } else {
          deferred.reject("Method '" + data_source_name + "' not defined on kawr";)
        }
      } else {
        deferred.reject("No data source name was defined");
      }
      
      return deferred.promise;
    }
}

Ah that makes things even more clear.
I guess I didn't completely read the comment you added in the last example

// This is subtle: The promise returned here will resolve/reject
// with the return value of on_success/on_error (unless they return undefined),

I was thinking I had to refactor it like so
when(result, reset_pending_items, reset_pending_items)

So I can think of all the .then() chains as mutators unless they return undefined. I guess I can go through and clean up my code a bit more in other places.

Thanks for the help :)

Raul

Thinking of them as mutators is a great way to put it--exactly right. The key is that promise and the promise returned by when or .then are different promises, and thus can have different resolution values.

Whether or not to mutate when undefined is returned is a bit of a gray area, since it's impossible to tell whether the callback intentionally returned undefined, or it simply didn't return a value at all. The Promises/A spec isn't fully clear on it, so I went with not mutating since that seems more intuitive to me ... I mean, how many times have you intentionally written return undefined?!?

BTW, not sure if it was obvious or not, but when(promise, callback, errback) and promise.then(callback, errback) are exactly the same. The advantage of when() is that it can handle situations where you don't know whether you have a promise or a value, e.g.: when(mightBeAPromiseOrARegularValue, callback, errback). It also tends to compress/minify slightly better than .then() :)