Skip to content

Instantly share code, notes, and snippets.

@ismyrnow
Last active August 29, 2015 14:26
Show Gist options
  • Select an option

  • Save ismyrnow/b2a403268d6e26030630 to your computer and use it in GitHub Desktop.

Select an option

Save ismyrnow/b2a403268d6e26030630 to your computer and use it in GitHub Desktop.
[Bug] Renamed QueryParams in transitionTo
import Ember from 'ember';
export default Ember.Controller.extend({
appName:'Ember Twiddle'
});
import Ember from 'ember';
export default Ember.Route.extend({
beforeModel: function (transition) {
this.transitionTo('test', {
queryParams: {
sidebar: true,
footer: true
}
});
}
});
import Ember from 'ember';
import config from './config/environment';
var Router = Ember.Router.extend({
location: config.locationType
});
Router.map(function() {
this.route('test');
});
export default Router;
import Ember from 'ember';
export default Ember.Controller.extend({
queryParams: [
'sidebar',
'footer'
//,{ isFooterVisible: 'footer' }
],
sidebar: false,
footer: false
});
<h2>test/template.hbs</h2>
<p>This fiddle demonstrates an issue where renamed query params cause a problem when passed in a call to "transitionTo".</p>
<p>If you rename the "footer" parameter to "isFooterVisible" (see commented code in test/controller.js), then the application will fail to load.</p>
sidebar?: {{#if sidebar}}Yes{{else}}No{{/if}}
<br>
footer?: {{#if footer}}Yes{{else}}No{{/if}}
<br>
isFooterVisible?: {{#if isFooterVisible}}Yes{{else}}No{{/if}}
{
"version": "0.4.6",
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/1.11.3/jquery.js",
"ember": "https://cdnjs.cloudflare.com/ajax/libs/ember.js/1.13.6/ember.js",
"ember-template-compiler": "https://cdnjs.cloudflare.com/ajax/libs/ember.js/1.13.6/ember-template-compiler.js"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment