Last active
August 27, 2020 18:34
-
-
Save j1elo/ee87931dd7c12053e30c366c5483c274 to your computer and use it in GitHub Desktop.
SDP preferred codec reordering
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* | |
* `codec` is a uppercase SDP-style codec name: "VP8", "H264". | |
* | |
* This looks for all video m-sections (lines starting with "m=video"), | |
* then searches all of its related PayloadTypes trying to find those which | |
* correspond to the preferred codec. If any is found, they are moved to the | |
* front of the PayloadTypes list in the m= line, without removing the other | |
* codecs that might be present. | |
* | |
* If our preferred coded is not found, the m= line is left without changes. | |
* | |
* This works based on the basis that RFC 3264 "Offer/Answer Model SDP" section | |
* 6.1 "Unicast Streams" allows the answerer to list media formats in a | |
* different order of preference from what it got in the offer: | |
* | |
* > Although the answerer MAY list the formats in their desired order of | |
* > preference, it is RECOMMENDED that unless there is a specific reason, | |
* > the answerer list formats in the same relative order they were | |
* > present in the offer. | |
* | |
* Here we have a specific reason, thus we use this allowance to change the | |
* ordering of formats. Browsers (tested with Chrome 84) honor this change and | |
* use the first codec provided in the answer, so this operation actually works. | |
*/ | |
private String setCodecPreference(String codec, String sdp) { | |
log.info("[setCodecPreference] codec: {}", codec); | |
List<String> codecPts = new ArrayList<String>(); | |
String[] lines = sdp.split("\r\n"); | |
Pattern ptRegex = Pattern.compile(String.format("a=rtpmap:(\\d+) %s/90000", codec)); | |
for (int sl = 0; sl < lines.length; sl++) { | |
String sdpLine = lines[sl]; | |
if (!sdpLine.startsWith("m=video")) { | |
continue; | |
} | |
// m-section found. Prepare an array to store PayloadTypes. | |
codecPts.clear(); | |
// Search the m-section to find our codec's PayloadType, if any. | |
for (int ml = sl + 1; ml < lines.length; ml++) { | |
String mediaLine = lines[ml]; | |
// Abort if we reach the next m-section. | |
if (mediaLine.startsWith("m=")) { | |
break; | |
} | |
Matcher ptMatch = ptRegex.matcher(mediaLine); | |
if (ptMatch.find()) { | |
// PayloadType found. | |
String pt = ptMatch.group(1); | |
codecPts.add(pt); | |
// Search the m-section to find the APT subtype, if any. | |
Pattern aptRegex = Pattern.compile(String.format("a=fmtp:(\\d+) apt=%s", pt)); | |
for (int al = sl + 1; al < lines.length; al++) { | |
String aptLine = lines[al]; | |
// Abort if we reach the next m-section. | |
if (aptLine.startsWith("m=")) { | |
break; | |
} | |
Matcher aptMatch = aptRegex.matcher(aptLine); | |
if (aptMatch.find()) { | |
// APT found. | |
String apt = aptMatch.group(1); | |
codecPts.add(apt); | |
} | |
} | |
} | |
} | |
if (codecPts.isEmpty()) { | |
continue; | |
} | |
// Build a new m= line where any PayloadTypes found have been moved | |
// to the front of the PT list. | |
StringBuilder newLine = new StringBuilder(sdpLine.length()); | |
List<String> lineParts = new ArrayList<String>(Arrays.asList(sdpLine.split(" "))); | |
if (lineParts.size() < 4) { | |
log.error("[setCodecPreference] BUG in m= line: Expects at least 4 fields: '{}'", sdpLine); | |
continue; | |
} | |
// Add "m=video", Port, and Protocol. | |
for (int i = 0; i < 3; i++) { | |
newLine.append(lineParts.remove(0) + " "); | |
} | |
// Add the PayloadTypes that correspond to our preferred codec. | |
for (String pt : codecPts) { | |
lineParts.remove(pt); | |
newLine.append(pt + " "); | |
} | |
// Add the rest of PayloadTypes. | |
newLine.append(String.join(" ", lineParts)); | |
// Replace the original m= line with the one we just built. | |
lines[sl] = newLine.toString(); | |
} | |
return String.join("\r\n", lines); | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment