Created
March 2, 2016 09:03
-
-
Save janimattiellonen/115777ee8687ebb47b5c to your computer and use it in GitHub Desktop.
A list of things you could check yourself before anyone else reviews your code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| A list of things you could check yourself before anyone else reviews your code: | |
| - all files must have an empty newline at OEF (use .editorconfig for that) | |
| - check for proper indentation (smarty indentations are often wrong after copy-paste) | |
| - remove unnecessary newlines | |
| - check that docblocks are valid and up-to-date | |
| - remove unnecessary if ($foo == true). if ($foo) should be enough | |
| - check that no merge conflict markers (>>>>>>>) are left behind | |
| - check for unused variables | |
| - extract long ifs to own method if possible | |
| - prefer '' over "" | |
| - remove commented code | |
| - .prop('disabled', true) instead of .attr('disabled', 'disabled') | |
| - run unit tests | |
| - run acceptance tests | |
| - run jshint | |
| - run severity tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment