Skip to content

Instantly share code, notes, and snippets.

@janschmutz
Created February 8, 2024 19:45
Show Gist options
  • Save janschmutz/46c795efae620ae7fd35f2011dda0aed to your computer and use it in GitHub Desktop.
Save janschmutz/46c795efae620ae7fd35f2011dda0aed to your computer and use it in GitHub Desktop.
Electron BrowserView not properly cleared on window.close()
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP -->
<meta http-equiv="Content-Security-Policy" content="default-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'">
<link href="./styles.css" rel="stylesheet">
<title>Hello World!</title>
</head>
<body>
<h1>Hello World!</h1>
We are using Node.js <span id="node-version"></span>,
Chromium <span id="chrome-version"></span>,
and Electron <span id="electron-version"></span>.
<button>Should be clickable if there is no browserView overlap</button>
<!-- You can also require other files to run in this process -->
<script src="./renderer.js"></script>
</body>
</html>
// Modules to control application life and create native browser window
const { app, BrowserWindow, BrowserView } = require('electron')
const path = require('node:path')
// Thanks for looking into this. To try simply start and type
// window.close() in the browser console. :)
async function createWindow () {
// Create the browser window.
const mainWindow = new BrowserWindow({
width: 800,
height: 600,
webPreferences: {
preload: path.join(__dirname, 'preload.js')
}
})
await mainWindow.loadFile('index.html')
// create a random browser view
const newView = new BrowserView({
webPreferences: {
// sandbox: false will close the app completely on window.close() :(
sandbox: true,
}
})
mainWindow.addBrowserView(newView)
// set a background color to show this better
newView.setBackgroundColor('#0000FF')
newView.setBounds({
x: 0,
y: 0,
width: 800,
height: 600,
})
newView.webContents.openDevTools()
newView.webContents.loadURL('https://google.com')
// I can catch the "destroyed" event but I am unable to properly remove / hide
// the actual browserView instance
newView.webContents.on('destroyed', () => {
console.log('Destroyed event fired')
// my naive attempts to fix
newView.setBounds({
x: 0,
y: 0,
width: 0,
height: 0,
})
mainWindow.removeBrowserView(newView)
})
}
// This method will be called when Electron has finished
// initialization and is ready to create browser windows.
// Some APIs can only be used after this event occurs.
app.whenReady().then(() => {
createWindow()
app.on('activate', function () {
// On macOS it's common to re-create a window in the app when the
// dock icon is clicked and there are no other windows open.
if (BrowserWindow.getAllWindows().length === 0) createWindow()
})
})
// Quit when all windows are closed, except on macOS. There, it's common
// for applications and their menu bar to stay active until the user quits
// explicitly with Cmd + Q.
app.on('window-all-closed', function () {
if (process.platform !== 'darwin') app.quit()
})
// In this file you can include the rest of your app's specific main process
// code. You can also put them in separate files and require them here.
{
"name": "selfish-payment-pass-w9fv8",
"productName": "selfish-payment-pass-w9fv8",
"description": "My Electron application description",
"keywords": [],
"main": "./main.js",
"version": "1.0.0",
"author": "janschmutz",
"scripts": {
"start": "electron ."
},
"dependencies": {},
"devDependencies": {
"electron": "28.2.0"
}
}
/**
* The preload script runs before. It has access to web APIs
* as well as Electron's renderer process modules and some
* polyfilled Node.js functions.
*
* https://www.electronjs.org/docs/latest/tutorial/sandbox
*/
window.addEventListener('DOMContentLoaded', () => {
const replaceText = (selector, text) => {
const element = document.getElementById(selector)
if (element) element.innerText = text
}
for (const type of ['chrome', 'node', 'electron']) {
replaceText(`${type}-version`, process.versions[type])
}
})
/**
* This file is loaded via the <script> tag in the index.html file and will
* be executed in the renderer process for that window. No Node.js APIs are
* available in this process because `nodeIntegration` is turned off and
* `contextIsolation` is turned on. Use the contextBridge API in `preload.js`
* to expose Node.js functionality from the main process.
*/
/* styles.css */
/* Add styles here to customize the appearance of your app */
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment