Created
June 19, 2023 16:18
-
-
Save jasonLaster/35f9b3bcaf20ccd469f85fdd4a5d2a75 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/packages/shared/test-suites/RecordingTestMetadata.ts b/packages/shared/test-suites/RecordingTestMetadata.ts | |
index b6d24bcbb..63606512b 100644 | |
--- a/packages/shared/test-suites/RecordingTestMetadata.ts | |
+++ b/packages/shared/test-suites/RecordingTestMetadata.ts | |
@@ -413,7 +413,11 @@ export async function processCypressTestRecording( | |
const annotations = userActionEventIdToAnnotations[id]; | |
- assert(annotations != null, `Missing annotations for test event (${command.name})`); | |
+ // assert(annotations != null, `Missing annotations for test event (${command.name})`); | |
+ if (annotations == null) { | |
+ console.log(`Missing annotations for test event (${command.name})`); | |
+ return null; | |
+ } | |
let beginPoint: TimeStampedPoint | null = null; | |
let endPoint: TimeStampedPoint | null = null; | |
@@ -466,7 +470,10 @@ export async function processCypressTestRecording( | |
}); | |
assert(beginPoint !== null, `Missing "step:start" annotation for test event ${id}`); | |
- assert(endPoint !== null, `Missing "step:end" annotation for test event ${id}`); | |
+ assert( | |
+ endPoint !== null, | |
+ `Missing "step:end" annotation for test event ${id} ${JSON.stringify(command)}` | |
+ ); | |
assert(resultPoint !== null, `Missing "step:end" annotation for test event ${id}`); | |
assert( | |
viewSourceTimeStampedPoint !== null, | |
@@ -588,7 +595,9 @@ export async function processGroupedTestCases( | |
let testRecordings: RecordingTestMetadataV3.TestRecording[] = []; | |
for (let index = 0; index < partialTestRecordings.length; index++) { | |
const legacyTest = partialTestRecordings[index]; | |
- const annotations = annotationsByTest[index]; | |
+ // const annotations = annotationsByTest[index]; | |
+ | |
+ console.log("Processing test", legacyTest.source.title); | |
const test = await processCypressTestRecording(legacyTest, annotations, replayClient); | |
testRecordings.push(test); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment