Skip to content

Instantly share code, notes, and snippets.

@jasonLaster
Created October 28, 2020 17:08
Show Gist options
  • Select an option

  • Save jasonLaster/a54b7f2bd75c2d78bc98c76acf4ffe19 to your computer and use it in GitHub Desktop.

Select an option

Save jasonLaster/a54b7f2bd75c2d78bc98c76acf4ffe19 to your computer and use it in GitHub Desktop.
diff --git a/devtools/client/framework/test/head.js b/devtools/client/framework/test/head.js
index 4af5f5b26599..53515b84b30f 100644
--- a/devtools/client/framework/test/head.js
+++ b/devtools/client/framework/test/head.js
@@ -195,8 +195,8 @@ function DevToolPanel(iframeWindow, toolbox) {
this._window = iframeWindow;
}
-DevToolPanel.prototype = {
- open: function() {
+.DevToolPanel.prototype = {
+ open: function () {
return new Promise(resolve => {
executeSoon(() => {
this._isReady = true;
@@ -224,7 +224,7 @@ DevToolPanel.prototype = {
_isReady: false,
- destroy: function() {
+ destroy: function () {
return Promise.resolve(null);
},
};
diff --git a/devtools/server/actors/replay/module.js b/devtools/server/actors/replay/module.js
index 5129f914bc23..0e410de1324f 100644
--- a/devtools/server/actors/replay/module.js
+++ b/devtools/server/actors/replay/module.js
@@ -378,6 +378,8 @@ const {
function eventListener(info) {
const event = eventBreakpointForNotification(gDebugger, info);
if (event && (info.phase == "pre" || info.phase == "post")) {
+ if (event == "event.mouse.click")
+ console.log(`>>> eventListener`, event, JSON.stringify(info));
RecordReplayControl.onEvent(event, info.phase == "pre");
}
}
diff --git a/devtools/startup/DevToolsStartup.jsm b/devtools/startup/DevToolsStartup.jsm
index ed4b8f911078..137dd340402a 100644
--- a/devtools/startup/DevToolsStartup.jsm
+++ b/devtools/startup/DevToolsStartup.jsm
@@ -307,9 +307,9 @@ function validateProfilerWebChannelUrl(targetUrl) {
console.error(
`The preference "devtools.performance.recording.ui-base-url" was set to a ` +
- "URL that is not allowed. No WebChannel messages will be sent between the " +
- `browser and that URL. Falling back to ${frontEndUrl}. Only localhost ` +
- "and deploy previews URLs are allowed.",
+ "URL that is not allowed. No WebChannel messages will be sent between the " +
+ `browser and that URL. Falling back to ${frontEndUrl}. Only localhost ` +
+ "and deploy previews URLs are allowed.",
targetUrl
);
}
@@ -592,7 +592,7 @@ DevToolsStartup.prototype = {
// Hardcode the addition of the "work offline" menuitem at the bottom:
itemsToDisplay.push({
localName: "menuseparator",
- getAttribute: () => {},
+ getAttribute: () => { },
});
itemsToDisplay.push(doc.getElementById("goOfflineMenuitem"));
@@ -1424,6 +1424,10 @@ function recordReplayLog(text) {
ChromeUtils.recordReplayLog = recordReplayLog;
function getLoggedInUser() {
+ if (isRunningTest()) {
+ return { id: "77c6dc81-280d-4f28-971b-9915ab00f0f7" }
+ }
+
const userPref = Services.prefs.getStringPref("devtools.recordreplay.user");
if (userPref == "") {
return;
@@ -1626,7 +1630,7 @@ function refreshAllRecordingButtons() {
node.refreshStatus();
}
}
- } catch (e) {}
+ } catch (e) { }
}
// When state changes which affects the recording buttons, we try to update the
@@ -1833,7 +1837,7 @@ async function reloadAndStopRecordingTab(gBrowser) {
const { recordingId } = data;
recordReplayLog(`FinishedRecording ${recordingId}`);
- saveRecordingInDB(data);
+ await saveRecordingInDB(data);
let viewHost = "https://replay.io";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment