James Bellenger jbellenger

async-graphql: Inline fragment with union type condition fails to match

Summary

When a query uses an inline fragment with a union type condition (e.g. ... on MyUnion), and the current runtime type is a member of that union, async-graphql fails to spread the fragment. The fields inside the fragment are silently dropped, resulting in empty data.

This affects both the dynamic schema API and macro-derived types.

Minimal reproduction

code-review-app

An application for conducting code review interviews

Backstory

This service ensures we are following the laws of the City of Atlantis with respect to vacation rental properties. Atlantis requires that:

Every bookable listing within their City limits has a valid registration number. This is obtained by hosts via an in-person application process. A single registration number applies to a single property and host, regardless of which

Keybase proof

I hereby claim:

I am jbellenger on github.
I am jbellenger (https://keybase.io/jbellenger) on keybase.
I have a public key ASCSDHwsebSWt8gROA9F_9D8lsRmLGWu47Yh0I7XTw_GLwo

To claim this, I am signing this object:

	// MultipleNestedClasses.java
	package javassist;

	public class MultipleNestedClasses {
	static class Nested1 {}
	static class Nested2 {}
	}


	// $ javac MultipleNestedClasses.java

	// All webpack chunks have an identifier that is written to both the chunk and
	// the chunk manifest.
	//
	// By default, webpack uses "int" identifiers, where the identifiers are
	// sequentially generated after chunks are ordered by OccurenceOrderPlugin.
	//
	// The result of this is that small code changes may cause chunks to be
	// reordered, leading to a cascading change of chunk ids, and a large number of
	// chunk rehashes that could have been avoided.
	//

	const crypto = require('crypto');
	const RawModule = require('./lib/RawModule');

	const hashModule = (module) => {
	const hash = crypto.createHash('sha256');
	module.updateHash(hash);
	return hash.digest('hex');
	};

	const hashFoo = hashModule(new RawModule('foo'));

	webpackJsonp([0],{

	/***/ "./entry.js":
	/***/ (function(module, exports) {

	document.getElementById('message').innerHTML = 'everything ok!';


	/***/ })

	webpackJsonp([0],{

	/***/ 11:
	/***/ (function(module, exports) {



	/***/ })

	});

	import akka.actor.{ActorSystem, Cancellable}
	import akka.http.Http
	import akka.http.model.{HttpRequest, HttpResponse, Uri}
	import akka.http.unmarshalling.Unmarshal
	import akka.stream.ActorFlowMaterializer
	import akka.stream.scaladsl._
	import akka.util.ByteString

	import scala.concurrent.duration._