Skip to content

Instantly share code, notes, and snippets.

@jbergstroem
Last active August 29, 2015 14:16
Show Gist options
  • Save jbergstroem/c83b5a7219ef8c4f08e1 to your computer and use it in GitHub Desktop.
Save jbergstroem/c83b5a7219ef8c4f08e1 to your computer and use it in GitHub Desktop.
thoughs on binpkg attachments to github releases

workflow from a "gh releases" point of view

See this as version -1. There's necessary changes to be made to Makefile, as well as introducing some shell scripts that does below. I have no clue how we'll do this on Windows. I also don't fully understand how builds on release-buildbots are triggered; but assume they're automated somehow. GH auth is currently through tokens which is suboptimal at best.

I'm also somewhat abusing the pre-release tag, but it at least shows that it should't be treated as "final".

  1. update src/node_version.h
  2. tag version
  3. push commit / tags
  4. create gh release as pre-release
  5. update release info with generic notes/changelog (suggesting human readable)
  6. release-buildbots confirm that there's an release build and creates binaries
  7. (optional, not currently feasible) release-buildbots verifies that test suite passes on their platform
  8. release-buildbots checks gh releases api and verifies there's no current uploaded binary from their platform/architecture
  9. release-buildbots uploads/attaches artifact to release
  10. once reviewed, $someone switches from pre-release to release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment