Removing duplication with Elm record syntax

1-Before.elm

playerDetailsViewModel : (PlayerId -> Int) -> PlayerModel -> PlayerDetailsViewModel
playerDetailsViewModel playerPointsScored playerModel =
    PlayerDetailsViewModel
        playerModel.id
        playerModel.name
        (playerPointsScored playerModel.id)

2-Destructuring.elm

playerDetailsViewModel : (PlayerId -> Int) -> PlayerModel -> PlayerDetailsViewModel
playerDetailsViewModel playerPointsScored { id, name } =
    PlayerDetailsViewModel
        id
        name
        (playerPointsScored id)

From my expereience in both OOP but even stronger from my experience in FP: it is not a good idea to flatten data. Yes you should not let the called function or method go deep into your structure and do what it want either. Instead you should use functors and or other pattern to embellish the methods and functions so that they don't need to know about the wrapping structures.

It would be interesting to see the usage of the view-model. Right now it seams like it would be better of just being a pair (or any product type).

getScore model = model |> .id |> playerPointsScored
-- mapRight getScore (model, model) --
-- (model, model |> getScore ) --

or something like that. I wish to make getScore dot free but i dont know elm good enough for that. Now the renderer dont need to know how to render a pair just how to render models and scores and you can use mapBoth to get both outputs and combine them later.