Skip to content

Instantly share code, notes, and snippets.

@jbweston
Created March 29, 2021 15:30
Show Gist options
  • Save jbweston/4407f7197ed69a47d8e3f67bb85f6ced to your computer and use it in GitHub Desktop.
Save jbweston/4407f7197ed69a47d8e3f67bb85f6ced to your computer and use it in GitHub Desktop.
Get miniver to raise UnknownVersion when it encounters an unknown veresion
@@ -10,6 +10,11 @@ from setuptools.command.sdist import sdist as sdist_orig
Version = namedtuple("Version", ("release", "dev", "labels"))
+
+class UnknownVersion(RuntimeError):
+ pass
+
+
# No public API
__all__ = []
@@ -35,7 +40,7 @@ def get_version(version_file=STATIC_VERSION_FILE):
if not version:
version = get_version_from_git_archive(version_info)
if not version:
- version = Version("unknown", None, None)
+ raise UnknownVersion()
return pep440_format(version)
else:
return version
@@ -116,10 +121,7 @@ def get_version_from_git():
try:
release, dev, git = description
except ValueError: # No tags, only the git hash
- # prepend 'g' to match with format returned by 'git describe'
- git = "g{}".format(*description)
- release = "unknown"
- dev = None
+ raise UnknownVersion()
labels = []
if dev == "0":
@@ -163,7 +165,7 @@ def get_version_from_git_archive(version_info):
release, *_ = sorted(version_tags) # prefer e.g. "2.0" over "2.0rc1"
return Version(release, dev=None, labels=None)
else:
- return Version("unknown", dev=None, labels=["g{}".format(git_hash)])
+ raise UnknownVersion()
__version__ = get_version()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment