a1.md

Answer to Question 1

That code violates Tell, Don't Ask..

You could also say it exhibits the feature envy smell.

Furthermore, "checking systems" shouldn't, necessarily, sound an alarm. The method both checks and responds to a state, and therefore has side effects. You might prefer to ONLY check the system without sounding an alarm.

(Violating Tell, Don't Ask and having feature envy are pretty much two sides of the same coin.)

q2.md

Question 2

What testing code smell do we have here?

describe "#full_name" do
  it "returns a concatenated full name" do
    user = User.new
    allow(user).to receive(:first_name).and_return("John")
    allow(user).to receive(:last_name).and_return("Smith")
    
    expect(user.full_name).to eq("John Smith")
  end
end

Click here for the answer