Skip to content

Instantly share code, notes, and snippets.

@jeanbza
Created October 18, 2019 16:58
Show Gist options
  • Save jeanbza/0495528478b88e594f5644d4daa03b22 to your computer and use it in GitHub Desktop.
Save jeanbza/0495528478b88e594f5644d4daa03b22 to your computer and use it in GitHub Desktop.
deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/storage on master
$ gotr TestIntegration_BucketUpdate
=== RUN TestIntegration_BucketUpdate
--- PASS: TestIntegration_BucketUpdate (2.33s)
=== RUN TestIntegration_BucketUpdate
--- FAIL: TestIntegration_BucketUpdate (0.26s)
integration_test.go:307: bucket should not have labels initially
FAIL
2019/10/18 10:56:31 deleting bucket "go-integration-test-20191003-77004343053000-0001", which is more than 24h0m0s old
2019/10/18 10:56:31 deleting bucket "go-integration-test-20191010-77286384765000-0001", which is more than 24h0m0s old
^CFAIL cloud.google.com/go/storage 9.770s
deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/storage on master
$ code
deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/storage on master
$ code .
deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/storage on master
$ gotr TestIntegration_BucketUpdate
=== RUN TestIntegration_BucketUpdate
--- PASS: TestIntegration_BucketUpdate (2.88s)
=== RUN TestIntegration_BucketUpdate
--- PASS: TestIntegration_BucketUpdate (2.76s)
PASS
2019/10/18 10:58:31 deleting bucket "go-integration-test-20191010-77286384765000-0001", which is more than 24h0m0s old
^CFAIL cloud.google.com/go/storage 9.120s
deklerk at deklerk-macbookpro2 in ~/workspace/google-cloud-go/storage on master*
$ git diff
diff --git a/storage/integration_test.go b/storage/integration_test.go
index 9303906c5..5690b55d4 100644
--- a/storage/integration_test.go
+++ b/storage/integration_test.go
@@ -293,11 +293,17 @@ func TestIntegration_BucketMethods(t *testing.T) {
}
func TestIntegration_BucketUpdate(t *testing.T) {
+ bucketName := uidSpace.New()
+
ctx := context.Background()
client := testConfig(ctx, t)
defer client.Close()
h := testHelper{t}
+ if err := client.Bucket(bucketName).Create(ctx, testutil.ProjID(), nil); err != nil {
+ log.Fatalf("creating bucket %q: %v", bucketName, err)
+ }
+
b := client.Bucket(bucketName)
attrs := h.mustBucketAttrs(b)
if attrs.VersioningEnabled {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment