pycodestyle_tox.md

Our default ignore pattern

There are issues found, so pycodestyle should report them.

$ /home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/.tox/codestyle/bin/pycodestyle --ignore=E111,E124,E126,E201,E202,E221,E241,E302,E501 twitter tests
tests/test_api_30.py:14:1: E402 module level import not at top of file
tests/test_api_30.py:37:27: E226 missing whitespace around arithmetic operator
tests/test_api_30.py:237:9: E303 too many blank lines (2)
tests/test_api_30.py:1026:45: E128 continuation line under-indented for visual indent
tests/test_api_30.py:1027:45: E128 continuation line under-indented for visual indent
tests/test_api_30.py:1028:45: E128 continuation line under-indented for visual indent
tests/test_api_30.py:1029:45: E128 continuation line under-indented for visual indent
tests/test_api_30.py:1458:33: W291 trailing whitespace
tests/test_api_30.py:1464:5: E303 too many blank lines (2)
tests/test_api_30.py:1499:5: E303 too many blank lines (2)
tests/test_api_30.py:1560:5: E303 too many blank lines (2)
tests/test_media.py:14:5: E301 expected 1 blank line, found 0

Running make tox with default ignore.

Issues found (no surprise), commands failed are reported from make, but pycodestyle reports an InvocationError.

$ make tox
rm -fr build
rm -fr dist
find . -name '*.pyc' -exec rm -f {} \;
find . -name '*.pyo' -exec rm -f {} \;
find . -name '*~' ! -name '*.un~' -exec rm -f {} \;
tox
GLOB sdist-make: /home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/setup.py
codestyle inst-nodeps: /home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/.tox/dist/python-twitter-3.1.zip
codestyle installed: future==0.15.2,oauthlib==1.1.2,pycodestyle==2.0.0,python-twitter==3.1,requests==2.10.0,requests-oauthlib==0.6.2
codestyle runtests: PYTHONHASHSEED='3208627063'
codestyle runtests: commands[0] | pycodestyle --ignore=E111,E124,E126,E201,E202,E221,E241,E302,E402,E226,E303,E128,E501,W291 twitter tests
tests/test_media.py:14:5: E301 expected 1 blank line, found 0
ERROR: InvocationError: '/home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/.tox/codestyle/bin/pycodestyle --ignore=E111,E124,E126,E201,E202,E221,E241,E302,E402,E226,E303,E128,E501,W291 twitter tests'
______________________________________________________ summary _______________________________________________________
ERROR:   codestyle: commands failed
make: *** [Makefile:43: tox] Error 1

Ignore every violation

However when there are no issues found, then pycodestyle reports success.

$ make tox
rm -fr build
rm -fr dist
find . -name '*.pyc' -exec rm -f {} \;
find . -name '*.pyo' -exec rm -f {} \;
find . -name '*~' ! -name '*.un~' -exec rm -f {} \;
tox
GLOB sdist-make: /home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/setup.py
codestyle inst-nodeps: /home/jeremy/coding/contrib/upstream-python-twitter/python-twitter/.tox/dist/python-twitter-3.1.zip
codestyle installed: future==0.15.2,oauthlib==1.1.2,pycodestyle==2.0.0,python-twitter==3.1,requests==2.10.0,requests-oauthlib==0.6.2
codestyle runtests: PYTHONHASHSEED='2623823828'
codestyle runtests: commands[0] | pycodestyle --ignore=E111,E124,E126,E201,E202,E221,E241,E302,E402,E226,E303,E128,E501,W291,E301 twitter tests
______________________________________________________ summary _______________________________________________________
  codestyle: commands succeeded
  congratulations :)

So for whatever reason we're getting an invocation error for linting failure. Like I said, that seems backwards and wrong, but it is what it (upstream) is.