Issues testing the threading_restructure branch of flapjack

jabber.rb stop wrong number of commands from pikelet.rb text

2013-08-09T18:24:18+09:30 [INFO] :: flapjack-email :: stopping email notifier
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/gateways/jabber.rb:466:in `stop': wrong number of arguments (1 for 0) (ArgumentError)
  from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:133:in `block in stop'
	from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:104:in `stop'
	from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:132:in `stop'
	from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/coordinator.rb:54:in `map'
	from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/coordinator.rb:54:in `block in start'
	from /Users/jesse/.rbenv/versions/1.9.3-p125/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
	from /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/coordinator.rb:52:in `start'
	from bin/flapjack:107:in `block in <main>'
	from bin/flapjack:152:in `call'
	from bin/flapjack:152:in `block in <main>'
	from bin/flapjack:15:in `call'
	from bin/flapjack:15:in `start'
	from /Users/jesse/.rbenv/versions/1.9.3-p125/lib/ruby/gems/1.9.1/gems/dante-0.1.5/lib/dante/runner.rb:72:in `execute'
	from bin/flapjack:151:in `<main>'

Oj json dump exception enqueueing a message

2013-08-09T18:24:18+09:30 [DEBUG] :: flapjack-notifier :: notification: media_to_use: {"jabber"=>"[email protected]", "pagerduty"=>"xxxxxxxx"}
2013-08-09T18:24:18+09:30 [INFO] :: flapjack-notifier :: Enqueueing email alert for foo-app-01.example.com:Foo to [email protected]
2013-08-09T18:24:18+09:30 [WARN] :: flapjack-notifier :: Failed to dump Flapjack::Data::TagSet Object to JSON in strict mode.

2013-08-09T18:24:18+09:30 [WARN] :: flapjack-notifier :: /Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/data/message.rb:15:in `dump'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/data/message.rb:15:in `push'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:144:in `block in process_notification'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:101:in `each'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:101:in `process_notification'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:61:in `block (3 levels) in start'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/data/notification.rb:100:in `foreach_on_queue'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:60:in `block (2 levels) in start'
/Users/jesse/.rbenv/versions/1.9.3-p125/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:59:in `block in start'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:58:in `loop'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/notifier.rb:58:in `start'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:120:in `block in start'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:74:in `block (3 levels) in start'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:72:in `loop'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:72:in `block (2 levels) in start'
/Users/jesse/.rbenv/versions/1.9.3-p125/lib/ruby/1.9.1/monitor.rb:211:in `mon_synchronize'
/Users/jesse/src/flpjck/flapjack-ali-graham/lib/flapjack/pikelet.rb:65:in `block in start'
2013-08-09T18:24:18+09:30 [INFO] :: flapjack-processor :: stopping processor
2013-08-09T18:24:18+09:30 [INFO] :: flapjack-email :: stopping email notifier

simulate-failed-check no work

with bundle exec:

jesse@Heart-of-Gold flapjack $ bundle exec bin/simulate-failed-check fail-and-recover --entity foo-app-01.example.com --check "Foo" -s 'CRITICAL' -t 10
bin/simulate-failed-check:10:in `require': cannot load such file -- eventmachine (LoadError)
  from bin/simulate-failed-check:10:in `<main>'

without:

jesse@Heart-of-Gold flapjack $ bin/simulate-failed-check fail-and-recover --entity foo-app-01.example.com --check "Foo" -s 'CRITICAL' -t 10
2013-08-09 18:59:19 +0930: sending failure event (CRITICAL) for foo-app-01.example.com:Foo
bin/simulate-failed-check:27:in `send_event': undefined method `add' for Flapjack::Data::Event:Class (NoMethodError)
	from bin/simulate-failed-check:45:in `fail'
	from bin/simulate-failed-check:140:in `<main>'

Anywhere 'wrong number of arguments (1 for 0)' this pops up for stop(), I've changed the pikelet stop() methods to take the thread to raise the exception against as a parameter, but failed to fix it everywhere.

It's actually symptomatic of some refactoring being needed, as half of the pikelets now block until being interrupted by a signal, then exit, while the other half process messages when signalled, and exit on an (otherwise unnotable) exception -- I need to formalise that in the code. I'll fix this over the next couple of days (on Monday if I can't do it today, busy tomorrow).

for simulate-failed-check -- I'll need to check the gems used across all of the scripts in bin/, and Event.add has changed name to Event.push as part of a common refactoring for the interruptible queue access from the threaded pikelets. I'll have to check if the parameters have changes as well, don't think so though.

Re Oj exception; yup, probably needs a .to_a serialization somewhere -- a test that triggers it before fixing would be good too, as tests passing but code failing isn't ideal. If this is something that has changed in the past few days the branch probably isn't up to date with the latest changes yet...

I've created issues for all the above at https://github.com/ali-graham/flapjack/issues