J. Wijaya jewijaya

MIT License

Copyright (c) [year] [fullname]

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

There are a bunch of reasons why this is convoluted, mostly in building the URL to make the request:

You have to rely on an AJAX request, this example uses jQuery
To make a GetFeatureInfo request, you must provide a BBOX for a image, and the pixel coordinates for the part of the image that you want info from. A couple of squirrely lines of Leaflet code can give you that.
Output formats. The info_format parameter in the request. We don't know a priori which will be supported by a WMS that we might make a request to. See Geoserver's docs for what formats are available from Geoserver. That won't be the same from WMS to WMS, however.
WMS services return XML docs when there's a mistake in the request or in processing. This sends an HTTP 200, which jQuery doesn't think is an error.

Here's a little walkthrough of how Yannick and I are using feature branches and pull requests to develop new features and adding them to the project. Below are the steps I take when working on a new feature. Hopefully this, along with watching the process on Github, will serve as a starting point to having everyone use a similar workflow.

Questions, comments, and suggestions for improvements welcome!

Start with the latest on master

When starting a new feature, I make sure to start with the latest and greatest codebase:

git checkout master

	//ref: https://codereview.stackexchange.com/questions/33053/optimization-of-comparing-two-collections-and-get-the-changes

	using BenchmarkDotNet.Attributes;
	using BenchmarkDotNet.Running;
	using System;
	using System.Collections.Concurrent;
	using System.Collections.Generic;
	using System.Linq;
	using System.Threading.Tasks;

	/// <summary>
	/// Process helper with asynchronous interface
	/// - Based on https://gist.github.com/georg-jung/3a8703946075d56423e418ea76212745
	/// - And on https://stackoverflow.com/questions/470256/process-waitforexit-asynchronously
	/// </summary>
	public static class ProcessAsyncHelper
	{
	/// <summary>
	/// Run a process asynchronously
	/// <para>To capture STDOUT, set StartInfo.RedirectStandardOutput to TRUE</para>