Created
November 15, 2024 17:01
-
-
Save jgaskins/41719f1dff8eaf09855dd6af1c247d3b to your computer and use it in GitHub Desktop.
Parse Postgres TIMESTAMPs from JSON blobs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CREATE FUNCTION text_to_timestamp(text) RETURNS TIMESTAMP | |
LANGUAGE sql IMMUTABLE AS | |
$$ | |
SELECT CASE | |
WHEN $1 ~ '^\d{4}-\d{2}-\d{2} \d{2}:\d{2}:\d{2}(\.\d+)?$' THEN | |
CAST($1 AS timestamp without time zone) | |
END | |
$$; | |
CREATE TABLE t ( | |
id SERIAL NOT NULL, | |
title VARCHAR(255) generated always as (item ->> 'title') stored, | |
start_date TIMESTAMP generated always as (text_to_timestamp(item ->> 'startDate')) stored, | |
item JSONB NOT NULL, | |
PRIMARY KEY(id) | |
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
IMMUTABLE
is the key.CAST(... AS timestamp)
does the same thing as::timestamp
. I think Postgres even transforms one into the other — I've seen that in query plans in the past, at least.Within the function, our
CASE
expression provides the guarantee that it returns atimestamp
value, orNULL
if it can't parse. If you declare the custom function asIMMUTABLE
without providing an appropriate guarantee, some weird things can happen. Let's say you omit the format validation and just wrap the simplest expression in anIMMUTABLE
function:Let's then imagine someone hits your API with the following JSON payload:
Note that the
startDate
is just the literal string"now"
. Postgres will put an actual timestamp into yourstart_date
column. On the surface, this seems awesome, but there are other consequences of relying on this behavior. The most frustrating is that updating the row will regeneratestart_date
:Note that
start_date
changed even though I only modifiedtitle
. This is almost certainly not what you want. I'm not even sure I'd use it as a poor-man's automaticupdated_at
column because I'm not sure what the consequences of indexing on this might be.