eliperkins

Implementing a Strong Code-Review Culture

As an author

• Provide more/sufficient context around changes
• Linking to the issue isn't always enough
• Challenge: 2 paragraphs of context

As a reviewer

• Offer compliments in PRs when you learn or something is done well
• Ask questions rather than make demands/commands, engage in conversation

traviskaufman

Better Jasmine Tests With this

On the Refinery29 Mobile Web Team, codenamed "Bicycle", all of our unit tests are written using Jasmine, an awesome BDD library written by Pivotal Labs. We recently switched how we set up data for tests from declaring and assigning to closures, to assigning properties to each test case's this object, and we've seen some awesome benefits from doing such.

The old way

Up until recently, a typical unit test for us looked something like this:

describe('views.Card', function() {