Skip to content

Instantly share code, notes, and snippets.

@jimfleming
Last active October 31, 2024 09:33
Show Gist options
  • Save jimfleming/00a8285d846fb25fe236 to your computer and use it in GitHub Desktop.
Save jimfleming/00a8285d846fb25fe236 to your computer and use it in GitHub Desktop.
Display the source blob
Display the rendered blob
Raw
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
@jimfleming
Copy link
Author

Yup, that’s correct. Just a typo.

@SPOREIII
Copy link

Thank you for writing this code, which greatly helped me to learn Hill model.
It seems that there is a problem with the cell 9:

def f_PEE(L_CE_norm, V_CE_norm): 
    return F_max * ((L_CE_norm - L_CE_opt) / (L_CE_opt * w)) * f_V(V_CE_norm)

should be

def f_PEE(L_CE_norm, V_CE_norm): 
    return F_max * np.power((L_CE_norm - L_CE_opt) / (L_CE_opt * w), 2) * f_V(V_CE_norm)

Refer to equation 7

@jimfleming
Copy link
Author

Hmm. That's possibly a typo or I may have removed it on purpose. It's been so long I don't remember.

@haoction
Copy link

Thank you for writing this code, which greatly helped me to learn Hill model. It seems that there is a problem with the cell 9:

def f_PEE(L_CE_norm, V_CE_norm): 
    return F_max * ((L_CE_norm - L_CE_opt) / (L_CE_opt * w)) * f_V(V_CE_norm)

should be

def f_PEE(L_CE_norm, V_CE_norm): 
    return F_max * np.power((L_CE_norm - L_CE_opt) / (L_CE_opt * w), 2) * f_V(V_CE_norm)

Refer to equation 7

The power is calculated in the following if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment