Created
December 14, 2018 00:35
-
-
Save jktravis/bfd6d7ac50bf7dd5bc81fd0edca3669b to your computer and use it in GitHub Desktop.
Comparing listener-based v non-listener approach of getting geojson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class Map extends Component { | |
loadIncidents = () => { | |
const { project, baseMapApi } = this.props; | |
this.incidentEntrySource = new VectorSource({ | |
format: new GeoJSON(), | |
url: `${baseMapApi}path/to/resource/${project.id}` | |
}); | |
this.incidentEntryLayer = new VectorLayer({ | |
source: this.incidentEntrySource, | |
style: getStyleForFeature | |
}); | |
this.incidentEntrySource.on("change", this.handleIncidentSourceChange); | |
this.incidentEntryLayer.setZIndex(9999); | |
this.map.addLayer(this.incidentEntryLayer); | |
}; | |
handleIncidentSourceChange = () => { | |
if (this.incidentEntrySource.getState() === OL_STATE.READY) { | |
/** | |
* Put all the incidents into state. | |
*/ | |
const { rootOrganization } = this.props.project; | |
this.setState( | |
() => ({ | |
incidents: compose( | |
keyByPrimaryKey, | |
map( | |
compose( | |
mapRootOrgDefaultHidden(rootOrganization), | |
mapFeatureData | |
) | |
) | |
)(this.incidentEntrySource.getFeatures()) | |
}), | |
() => { | |
/** | |
* Un-sub. | |
*/ | |
this.incidentEntrySource.un( | |
"change", | |
this.handleIncidentSourceChange | |
); | |
if (this.isUsingDefaultCoords(history)) { | |
this.zoomToAllIncidents(); | |
} | |
/** | |
* These specific slices of the incidents need to be processed _after_ the incidents | |
* were originally added. | |
*/ | |
const { incidents } = this.state; | |
this.handleKmlFeatures(Object.values(incidents)); | |
} | |
); | |
} | |
}; | |
// the rest | |
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class Map extends Component { | |
loadIncidents = () => { | |
const { project } = this.props; | |
getResourceAsGeoJson(project.id) | |
.then(data => { | |
const features = new GeoJSON({featureProjection: 'ESPG:3857'}).readFeatures(data); | |
this.incidentEntrySource = new VectorSource({ | |
features, | |
}); | |
this.incidentEntryLayer = new VectorLayer({ | |
source: this.incidentEntrySource, | |
style: getStyleForFeature | |
}); | |
this.incidentEntryLayer.setZIndex(9999); | |
this.map.addLayer(this.incidentEntryLayer); | |
this.handleIncidentSourceChange(); | |
}) | |
}; | |
handleIncidentSourceChange = () => { | |
/** | |
* Put all the incidents into state. | |
*/ | |
const { rootOrganization } = this.props.project; | |
this.setState( | |
() => ({ | |
incidents: compose( | |
keyByPrimaryKey, | |
map( | |
compose( | |
mapRootOrgDefaultHidden(rootOrganization), | |
mapFeatureData | |
) | |
) | |
)(this.incidentEntrySource.getFeatures()) | |
}), | |
() => { | |
if (this.isUsingDefaultCoords(history)) { | |
this.zoomToAllIncidents(); | |
} | |
/** | |
* These specific slices of the incidents need to be processed _after_ the incidents | |
* were originally added. | |
*/ | |
const { incidents } = this.state; | |
this.handleKmlFeatures(Object.values(incidents)); | |
} | |
); | |
}; | |
// the rest | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment