| Metric | Before | After |
|---|---|---|
| Total Lines | 160 | ~110 |
| Duplicated Lines | ~70 (44%) | ~10 (9%) |
| Test Methods | 2 | 2 |
| Helper Methods | 0 | 3 |
Review of tests/test_trs_id.py from the TRS ID support branch (claude/add-trs-id-support-mefAv). The branch adds support for running workflows via TRS IDs like workflow/github.com/iwc-workflows/parallel-accession-download/main.
| commit fa276e6532ba34939ce7d796370f679526e986e9 | |
| Author: John Chilton <[email protected]> | |
| Date: Fri Dec 19 11:16:09 2025 -0500 | |
| Add tool_shed_url config for explicit hostname setting | |
| Allows admins to set a fixed base URL for clone URLs and repository | |
| hostnames, useful when behind proxies or needing a specific public URL. | |
| 🤖 Generated with [Claude Code](https://claude.com/claude-code) |
Overall this is a solid test suite that covers the core functionality well. The tests are mostly focused on behavior, have clear names, and are independent. Mutation testing confirmed backward() behavior is properly tested.
| diff --git a/test/integration/test_history_archiving.py b/test/integration/test_history_archiving.py | |
| index 2bbcb91ccb..e12c193fdd 100644 | |
| --- a/test/integration/test_history_archiving.py | |
| +++ b/test/integration/test_history_archiving.py | |
| @@ -229,7 +229,7 @@ class TestHistoryArchivingWithExportRecord(PosixFileSourceSetup, IntegrationTest | |
| ) | |
| self.dataset_populator.export_history_to_uri_async(history_id, target_uri, model_store_format) | |
| export_records = self.dataset_populator.get_history_export_tasks(history_id) | |
| - assert len(export_records) == 1 | |
| + assert len(export_records) >= 1 |
This plan implements History Notebooks - markdown documents tied to Galaxy histories that use HID-relative references. The feature enables human-AI collaborative analysis documentation with paths to Pages and Workflow Reports.
Reference Documents:
THE_PROBLEM_AND_GOAL.md- Vision and motivationRESEARCH_FOR_PLANNING.md- Backend implementation researchRESEARCH_FOR_PLANNING_UX.md- Frontend/UX implementation research
Add link to IWC (Intergalactic Workflow Commission) curated workflows at https://iwc.galaxyproject.org/ in Galaxy's workflow list interface. Implement BOTH a tab approach and a banner approach so you can decide which works better.
- IWC has 100+ vetted bioinformatics workflows
- Current WorkflowList has 3 tabs: My workflows, Shared with me, Public workflows
- No existing IWC integration in frontend
- Uses Vue 3 + Bootstrap Vue + TypeScript
I'm review a PR. It adds this file lib/galaxy/files/sources/omero.py - which is implementing a Galaxy File Source plugins. I'm worried about the size of the file - it seems large and it interwines plugin implementation logic and API communication a lot - would it make sense to extract the API interaction layer out and reduce the size of the plugin or does it make more sense as is?
Based on my analysis, here's my assessment:
Current implementation in wes.py:
_build_task_logs()(lines 886-913): Loads ALL WorkflowInvocationSteps into memory, then all related Jobs- Used in 3 places:
get_run_tasks()(line 701) - loads all, slices in Pythonget_run_task()(line 742) - loads all to find one_invocation_to_run_log()(line 868) - populates deprecated field