Scala Programming Taste

taste.scala

// Which of these is a better style? Is there much of a difference?

def createMicrosoftAudio0(utterance: Utterance, svc: MsSynthSvc = MicrosoftSpeech.Synthesize): Future[SynthesizedSpeech] = {
  if(!utterance.text.isDefined) return Future.exception(new UtteranceTextNotFound(utterance))  
  val req = SynthesizeRequest(utterance.convo.id, utterance.text.get)
  for {
    resp <- svc(req)
  } yield SynthesizedSpeed(resp._1, resp._2)
}

def createMicrosoftAudio1(utterance: Utterance, svc: MsSynthSvc = MicrosoftSpeech.Synthesize): Future[SynthesizedSpeech] = {
  if(utterance.emptyText) return Future.exception(new UtteranceTextNotFound(utterance))  
  val req = SynthesizeRequest.fromUtterance(utterance)
  svc(req).map(SynthesizedSpeech)
}

Given the generalised Speech client façade I've created, direct "extractors" would prolly be nice:

object Utterance {
   …

   object Recognised {
     def unapply(utterance: Utterance): Option[SpeechRequest] = utterance.text match {
       case Some(text) if text.nonEmpty => Some(SpeechRequest(utterance.convo.id, text))
       case _ => None
     }
   }

  object Unrecognised {
    def unapply(utterance: Utterance): Option[UtteranceTextNotFound] = utterance.text match {
      case Some(text) if text.isEmpty => Some(UtteranceTextNotFound(utterance))
      case None => Some(UtteranceTextNotFound(utterance))
      case _ => None
    }
}

and then

def createAudio(utterance: Utterance, svc: SpeechClient): Future[SpeechResponse] = utterance match {
  case Utterance.Recognised(request) => svc(request)
  case Utterance.Unrecognised(error) => Future.exception(error)
}