Skip to content

Instantly share code, notes, and snippets.

@johannth

johannth/code-review-agreement.md

Last active August 29, 2015 14:25
Show Gist options
  • Save johannth/4bee91809cc98c5dcebc to your computer and use it in GitHub Desktop.
Save johannth/4bee91809cc98c5dcebc to your computer and use it in GitHub Desktop.
Download ZIP
QuizUp iOS Code Review Agreement
Raw
code-review-agreement.md

Code Review Agreement

As the coder, what do I expect of the reviewer?

  • Be critical! I won't take it personally!
  • Thou shalt always weakify strongify! (i.e. reviewer spots dumb things)
  • Suggest alternatives and share knowledge.
  • Build and run code locallly.
  • Take your time to review.
  • Try to spot missing tests.

As a reviewer, what do I expect of the PR?

  • Code follows style and patterns.
  • Relevant and clear description with link to asana task.
  • Tests pass on CI system.
  • Code is shippable.
  • Doesn't try to hide hacks.
  • Small and focused PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment