Last active
August 29, 2015 14:14
-
-
Save johnbender/135900e88d50636c2043 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ## Review Feb 5 | |
| ### Misc. | |
| Artifacts like `node_modules` should be created by each user during an `npm install` so we can add them to the `.gitignore` | |
| https://github.com/wastatickets/wasta/blob/master/.gitignore | |
| I think we can remove the `jade` dependency since we're using `ejs`. | |
| https://github.com/wastatickets/wasta/blob/master/package.json#L14 | |
| ### Conventions | |
| Whitespace, 2 spaces, no tabs. | |
| https://github.com/wastatickets/wasta/commit/84a3c362d6ea941acc8afb00cbd0c812b940fc37 | |
| ### Views | |
| index.ejs | |
| Page structure should be: | |
| ```html | |
| <!DOCTYPE html> | |
| <html> | |
| <head> | |
| </head> | |
| <body> | |
| </body> | |
| </html> | |
| ``` | |
| https://github.com/wastatickets/wasta/commit/ba394ee34fe1fdbbb9308eed743bd972c2229c3b | |
| When in doubt you can always go to http://demo.html5boilerplate.com/ and view source. | |
| `meta` and `link` tags should go in the `head` | |
| https://github.com/wastatickets/wasta/commit/0de1de8cba73cec71d21364302d794cb15572c00 | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment