johnmdonahue/gist:3319797

Created August 11, 2012 01:30

Star (0) You must be signed in to star a gist
Fork (0) You must be signed in to fork a gist

Learn more about clone URLs
Clone this repository at <script src="https://gist.github.com/johnmdonahue/3319797.js"></script>
Save johnmdonahue/3319797 to your computer and use it in GitHub Desktop.

EE Mocha Port Questions

Raw

I ran into a few things working on the mocha port, these are the ones I was smart enough to write down but if the others come to me I'll let you know.

Would it make sense to give both the preview and edit iframes a div with an id or at least give the bodies id's? It would make this simpler: https://github.com/OscarGodson/EpicEditor/blob/858425d10a8e23eb3303d4847b0781f09f7dce67/test/test.getElement.js#L40
Why does the editor throw an error on multiple unloads instead of just ignoring it like load? Maybe we can just check to see if it's loaded and if not don't unload it. Thoughts?

OscarGodson commented Aug 11, 2012

FWIW, the reason why I changed my mind was seeing who was using the editor. It was more designery people, not JS really hardcore JS devs who know how to handle and errors and what they mean. I got a couple people asking why the errors were there and if it would break anything.