Skip to content

Instantly share code, notes, and snippets.

@johnmurrayvi
Last active December 19, 2015 20:58
Show Gist options
  • Save johnmurrayvi/6016469 to your computer and use it in GitHub Desktop.
Save johnmurrayvi/6016469 to your computer and use it in GitHub Desktop.
Changes:
getSkinDescription: function getSkinDescription(internalName) {
+ dump("sbFeathersManager::getSkinDescription(internalName = "+internalName+")\n");
return this._skins[internalName];
},
...
getLayoutDescription: function getLayoutDescription(url) {
+ dump("sbFeathersManager::getLayoutDescription(url = "+url+")\n");
return (url in this._layouts ? this._layouts[url] : null);
},
...
switchFeathers: function switchFeathers(layoutURL, internalName) {
// don't allow this call if we're already switching
if (this._switching) {
return;
}
+ dump("sbFeathersManager::switchFeathers(layoutURL = "+layoutURL+", internalName = "+internalName+")\n");
var layoutDescription = this.getLayoutDescription(layoutURL);
var skinDescription = this.getSkinDescription(internalName);
+ dump("sbFeathersManager::switchFeathers -- layoutDescription = "+layoutDescription+"\n");
+ dump("sbFeathersManager::switchFeathers -- skinDescription = "+skinDescription+"\n");
// Make sure we know about the requested skin and layout
if (layoutDescription == null || skinDescription == null) {
throw new Components.Exception("Unknown layout/skin passed to switchFeathers");
}
Output:
sbFeathersManager::getLayoutDescription(url = chrome://coppery/content/xul/mainplayer.xul)
-1387210944[7f03ac12e480]: nsComponentManager: CreateInstanceByContractID(@mozilla.org/supports-string;1) succeeded
sbFeathersManager::getSkinDescription(internalName = coppery)
-1387210944[7f03ac12e480]: nsComponentManager: CreateInstanceByContractID(@mozilla.org/scripterror;1) succeeded
JavaScript strict warning: file:///mnt/git/nightingale/nightingale/compiled/dist/components/sbFeathersManager.js, line 781: reference to undefined property this._skins[internalName]
-1387210944[7f03ac12e480]: file file:///mnt/git/nightingale/nightingale/compiled/dist/components/sbFeathersManager.js, line 781: reference to undefined property this._skins[internalName]
sbFeathersManager::switchFeathers(layoutURL = chrome://coppery/content/xul/mainplayer.xul, internalName = coppery)
sbFeathersManager::getLayoutDescription(url = chrome://coppery/content/xul/mainplayer.xul)
sbFeathersManager::getSkinDescription(internalName = coppery)
sbFeathersManager::switchFeathers -- layoutDescription = null
sbFeathersManager::switchFeathers -- skinDescription = undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment