Last active
December 16, 2015 08:49
-
-
Save jonaphin/5408611 to your computer and use it in GitHub Desktop.
code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if(@app.is_site_cat_enabled?) | |
| raw %Q{ | |
| CO.Events.trigger('navigate_screen', $.extend(#{opts}, { | |
| screen_permanent_id: '#{navigation_target.permanent_id}', | |
| source_component_id: '#{source_component.id}' | |
| })); | |
| } + sc_trigger | |
| else | |
| raw %Q{ | |
| CO.Events.trigger('navigate_screen', $.extend(#{opts}, { | |
| screen_permanent_id: '#{navigation_target.permanent_id}', | |
| source_component_id: '#{source_component.id}' | |
| })); | |
| return false; | |
| } | |
| end | |
| to | |
| return_false = sc_trigger.blank? ? "return false;" : "" | |
| raw %Q{ | |
| CO.Events.trigger('navigate_screen', $.extend(#{opts}, { | |
| screen_permanent_id: '#{navigation_target.permanent_id}', | |
| source_component_id: '#{source_component.id}' | |
| })); | |
| #{return_false} | |
| } + sc_trigger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment