Skip to content

Instantly share code, notes, and snippets.

@joshuajhun
Created November 7, 2017 15:50
Show Gist options
  • Save joshuajhun/9e919784ff55d3f9fda65642a6d817fe to your computer and use it in GitHub Desktop.
Save joshuajhun/9e919784ff55d3f9fda65642a6d817fe to your computer and use it in GitHub Desktop.

What's this PR do?

Describe the problem or feature in addition to a link to the issues. Delete any content that doesn't apply.

Pre-Merge TODOs

  • Screenshots Included
    • ANY change to the UI of the app must have screenshots/gifs
    • Hint: recordit is really great for this
  • Tests Added
    • ANY change that can be tested must include testing
  • Updated Documentation
    • Update your README if any new dependencies are added
  • Add follow up issues?
  • 2 PR reviews completed

Learning

Describe the research stage. Links to blog posts, patterns, libraries or add-ons used to solve this problem.

Where should the reviewer start?

What should the reviewer look at. Are there any potential red flags or concerns you have? How will the reviewer see the code (can they run it locally, etc?)

Any background context you want to provide?

Screenshots (if appropriate)

What gif best describes this PR or how it makes you feel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment