Skip to content

Instantly share code, notes, and snippets.

@jraczak
Created October 15, 2012 16:31
Show Gist options
  • Select an option

  • Save jraczak/3893440 to your computer and use it in GitHub Desktop.

Select an option

Save jraczak/3893440 to your computer and use it in GitHub Desktop.
# ORIGINAL METHOD
def change_owner
@shared_expense = SharedExpense.find(params[:id])
current_owner = @shared_expense.user
roomies = @shared_expense.dwelling.roomies.sort_by { |roomie| roomie.id }
next_owner_index = roomies.index {|roomie| roomie.id == current_owner.id} + 1
next_owner = roomies[next_owner_index]
@shared_expense.user_id = next_owner.id
@shared_expense.save
redirect_to current_user.dwelling
end
# REFACTORED METHOD
def change_owner
@shared_expense = SharedExpense.find(params[:id])
current_owner = @shared_expense.user
roomies = @shared_expense.dwelling.roomies.sort_by { |roomie| roomie.id }
next_owner_index = roomies.index {|roomie| roomie.id == current_owner.id} + 1
@shared_expense.user_id = roomies[next_owner_index].id
@shared_expense.save
redirect_to current_user.dwelling
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment