Created
March 14, 2018 11:17
-
-
Save juliandescottes/5405b9a4b2c5a0da377f83a82bc9bcac to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Questions | |
1 - Panel skeleton | |
The goal is to start with a basic skeleton that fits our needs but would evolve | |
naturally to what console/netmonitor look like today. In aboutdebugging, we said | |
"no redux in the beginning", but in the end we have inconsistent code compared to | |
React panels. | |
Looking at the current netmonitor and console folders, I'd like to start with the following folder hierarchy: | |
+ (?src) | |
|- + actions | |
|- + assets | |
|- + components | |
|- + (?middleware) | |
|- + reducers | |
|- + selectors | |
+ test | |
|- + unit | |
|- + browser | |
- index.html | |
- initializer.js (loaded by index.html) | |
- panel.js (loaded by the toolbox) | |
2 - Stylesheets | |
Netmonitor has css in assets/styles, console has some in net/components? Any advice here? | |
3 - Testing | |
In aboutdebugging, we always assert the DOM, with a lot of waitUntil everywhere. | |
I also see some of that in mochitests for the console and the netmonitor. | |
Are you also testing state? | |
Would you recommend going for alternative test suites (e.g. Mocha). | |
I see a lot of folders under webconsole/new-console-output/test, can we walk through those? | |
4 - Performance | |
Things to keep in mind for performance? | |
eg listen to visibility switch, | |
when to use PureComponents, | |
should we still use immutable, | |
libraries to use/avoid | |
5 - Other general advice? Launchpad? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment