juliandescottes

# HG changeset patch
# User Julian Descottes <[email protected]>
# Date 1537770943 -7200
#      Mon Sep 24 08:35:43 2018 +0200
# Node ID e5d16a78efe5dc96a0540cc0d54db18ba01e455a
# Parent  3e0166df6ac292dd863b1bc62672b27a7a1f1dfa
WIP WIP WIP ADB EXTENSION HELPER

diff --git a/devtools/client/aboutdebugging-new/src/modules/usb-runtimes.js b/devtools/client/aboutdebugging-new/src/modules/usb-runtimes.js
--- a/devtools/client/aboutdebugging-new/src/modules/usb-runtimes.js

juliandescottes

diff --git a/src/js/utils/serialization/Deserializer.js b/src/js/utils/serialization/Deserializer.js
index f8f532c..bcb3c26 100644
--- a/src/js/utils/serialization/Deserializer.js
+++ b/src/js/utils/serialization/Deserializer.js
@@ -36,6 +36,7 @@
 
     var descriptor = new pskl.model.piskel.Descriptor(name, description);
     this.piskel_ = new pskl.model.Piskel(piskelData.width, piskelData.height, piskelData.fps, descriptor);
+    this.hiddenFrames = piskelData.hiddenFrames || [];
 

juliandescottes

NetworkLocations module?

I have several options to handle network locations. First of all, let's assume I am using preferences to store the value.

Basically the code to add a location to the prefs looks like:

  function addLocation(location) {
    const Services = require("Services");
    const PREF = "devtools.aboutdebugging.network-locations";

juliandescottes

diff --git a/dom/base/CustomElementRegistry.cpp b/dom/base/CustomElementRegistry.cpp
--- a/dom/base/CustomElementRegistry.cpp
+++ b/dom/base/CustomElementRegistry.cpp
@@ -1,22 +1,26 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 

juliandescottes

# when opening a fully empty debugger
resource://devtools/client/debugger/new/src/main.js
resource://devtools/client/debugger/new/vendors.js
resource://devtools/client/shared/vendor/react.js
resource://devtools/client/shared/vendor/react-dom.js
resource://devtools/client/shared/source-map/index.js
resource://devtools/client/debugger/new/src/client/index.js
resource://devtools/client/debugger/new/src/client/firefox.js
resource://devtools/client/debugger/new/src/client/firefox/commands.js
resource://devtools/client/debugger/new/src/client/firefox/events.js

juliandescottes

# HG changeset patch
# User Julian Descottes <[email protected]>
# Date 1522448117 -7200
#      Sat Mar 31 00:15:17 2018 +0200
# Node ID b7818b24c7977c3bdf3eb00dd64aff4ad352d068
# Parent  0405f6006f3a3f653dd42d587c3eefe08cffa37d
Backed out changeset aee255d8336c

MozReview-Commit-ID: 68v5gVWVC0Q

juliandescottes

Shortlist of commits to uplift to 60 Beta as release 19.3:
- Prevent items[selectedIndex] error (#5517) 
  https://github.com/devtools-html/debugger.html/commit/14ab3b28519b89160b342b2a66dc0de8681842e9
- [Editor] Prevent multiple search boxes from opening on Windows (#5569)
  https://github.com/devtools-html/debugger.html/commit/c42e3f3b72b92824624f6d14b3e07e0ed553d3f6
- Removes sad face when source+goto (#5444) 
  https://github.com/devtools-html/debugger.html/commit/ff59534df48a064757c057f008034c5917ae42a3
- fix tabs using the selected source (#5535) 
  https://github.com/devtools-html/debugger.html/commit/c19ae46247cf77592b443bd6c675d6004229c4d6
- Give command bar buttons full background on hover (#5548) 

juliandescottes

Questions 

1 - Panel skeleton

The goal is to start with a basic skeleton that fits our needs but would evolve 
naturally to what console/netmonitor look like today. In aboutdebugging, we said 
"no redux in the beginning", but in the end we have inconsistent code compared to 
React panels.

Looking at the current netmonitor and console folders, I'd like to start with the following folder hierarchy:

juliandescottes

# HG changeset patch
# User Julian Descottes <[email protected]>
# Date 1520277297 -3600
#      Mon Mar 05 20:14:57 2018 +0100
# Node ID cc20e5c6b4cb54dde9fa3362afc46a45a7990f21
# Parent  8109be9a13aca79b3f4bf22dd2847b24ad820f52
WIP - wait for grid panel update before starting layoutview tests

MozReview-Commit-ID: 3RWpI1pbsj9

juliandescottes

diff --git a/packages/devtools-launchpad/webpack.config.devtools.js b/packages/devtools-launchpad/webpack.config.devtools.js
index be7f9cb..f7f9bc2 100644
--- a/packages/devtools-launchpad/webpack.config.devtools.js
+++ b/packages/devtools-launchpad/webpack.config.devtools.js
@@ -31,6 +31,21 @@ module.exports = (webpackConfig, envConfig, options) => {
       return;
     }
 
+    // I would like to run this only for parser-worker but I'm not sure how :)
+    if (request.includes("lodash/")) {