Skip to content

Instantly share code, notes, and snippets.

@justindag
Created November 11, 2016 20:51
Show Gist options
  • Select an option

  • Save justindag/e0a893abe5641be388fa51af9df42318 to your computer and use it in GitHub Desktop.

Select an option

Save justindag/e0a893abe5641be388fa51af9df42318 to your computer and use it in GitHub Desktop.
PP Go-Example Redux Meeting Notes

#PP Gophers Meeting

##Agenda

  • Request for items
  • PP Go-Example Redux code walk-through
  • PP Go-Example Redux discussion
  • Next meeting lead

##PP Go-Example Redux

  • restate goals:
    • minimal
    • simplified, cleaner code
    • more idiomatic
    • remove db code
    • production readiness (or as close to it as possible)
      • graceful process control
      • bugsnag integration
      • exe-only docker images
    • avoid premature abstractions and optimizations
  • project/directory structure
  • discussion points
    • server package Server struct vs funcs
    • recover wrapper middleware? do we really need it? "let it crash"? -- no, but need better restart
    • context wrapper [middleware]
    • include a sample 'business logic' package (that uses context)??
    • verify README instructions
    • env configs
      • port (req)
      • env (req)
    • docker & stats
  • the future
    • tls (nginx?)
    • codegen, gopp new foobar
    • more env configs
    • some background on services based on this (for specific examples)

##Action Items & Follow-Ups

  • assign next meeting lead
  • improve auth request middleware & stats [ay]
  • error codes in request stats [ay]
  • update data response with experiments reflection magic [jen]
  • paginated response type (from pricegun) [chris]
  • for now exclude rate limit middleware
  • no server struct [jd]
  • context wrapper middleware -- request id, passed from rails [carlos]
  • add example biz package that uses context and is wired to a handler [jd]
  • incl changelog [ay]
  • support head health check? [paul w]
  • add MAINTAINERS file [jd]
  • include error codes in README API section [jd/chris]
  • "how to contribute" section in README [jd]
  • how to clone this thing in README [jd]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment