-
-
Save jwilson8767/db379026efcbd932f64382db4b02853e to your computer and use it in GitHub Desktop.
// MIT Licensed | |
// Author: jwilson8767 | |
/** | |
* Waits for an element satisfying selector to exist, then resolves promise with the element. | |
* Useful for resolving race conditions. | |
* | |
* @param selector | |
* @returns {Promise} | |
*/ | |
export function elementReady(selector) { | |
return new Promise((resolve, reject) => { | |
let el = document.querySelector(selector); | |
if (el) { | |
resolve(el); | |
return | |
} | |
new MutationObserver((mutationRecords, observer) => { | |
// Query for elements matching the specified selector | |
Array.from(document.querySelectorAll(selector)).forEach((element) => { | |
resolve(element); | |
//Once we have resolved we don't need the observer anymore. | |
observer.disconnect(); | |
}); | |
}) | |
.observe(document.documentElement, { | |
childList: true, | |
subtree: true | |
}); | |
}); | |
} |
import { elementReady } from "es6-element-ready"; | |
// Simple usage to delete an element if/when it exists: | |
elementReady('#someWidget').then((someWidget)=>{someWidget.remove();}); |
@LouisDeconinck @jwilson8767 Should work by simply concatenating with a comma same as you would to define a CSS style for two totally different selectors:
elementReady('#element1, #element2, .element3').then((el) => doSomethingWith(el))
Thank you bro!
This is querying the entire document every time a mutation occurs, rather than matching specifically against the added nodes. This may result in a performance issue.
Yes, what @bezborodow is recommending is that instead of doing a document.querySelectorAll(selector)
on line 20, it is more efficient to only try to match on the added notes in the mutationRecords
parameters (ex. check if mutationRecords[0].addedNodes[0].matches(selector)
, and repeat for all mutationRecords
and addedNodes
).
Even if performance is better, I don't think this strategy works in all cases. One reason: adding a node such as <div>This div has <strong>children</strong></div>
will put the outer div into the addedNodes
list, but none of its children will be in addedNodes
. So, matching on 'div > strong'
would not succeed. You could instead do addedNode.querySelectorAll(selector)
for all added nodes, but there are other CSS selectors for which this is insufficient. One example that comes to mind is '#parentElem:has(div > strong)'
. Even if adding the nodes would cause a valid match, #parentElem is never part of addedNodes
, because that particular node was never added. I believe using + and ~ in selectors is similarly problematic.
tl;dr Referring to addedNodes
might be more performant, but it can fail to match in some scenarios. document.querySelectorAll might be inefficient, but it is always correct.
@acropup, an alternative solution is to match on the unique ID only, and not use selectors. This would be intuitive, since the promise resolves after the first match is found.
However, if there was a way to reliably tokenise a selector, it could be found through introspection what kind combinators are present and adjust the match/query algorithm accordingly. There is a css-selector-tokenizer
package, but that seems overkill for something that should be easily achievable.
section:has(div > strong)
example using closest()
. Adjacent and sibling combinators can also be implemented, but the important aspect in terms of performance is having a tokeniser to introspect and recognise which algorithm to pick based on the complexity of the selector. Although even without that, this should represent a substantial improvement.
const element = (addedNode.matches(selector) && addedNode)
|| addedNode.querySelector(selector)
|| addedNode.closest(selector);
ok boo
Is it possible to reuse the same MutationObserver multiple times without calling disconnect() on it? If the MutationObserver is observing the document, then if I am able to reuse it for all new node creations on the document, i wont have to keep creating/disconnecting it.
@precogtyrant MutationObserver's themselves with a callback function are probably your best bet then instead of using elementReady()
since promises can by nature only be resolved once. If you want more robust "reactive" / "observable" behavior, I can't recommend RXJS enough. I've used it to build entire apps, and it's really a game changer.
@bezborodow Regarding performance issues, elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:
// dict of {selector: [promise, resolve]}
const pendingElements = {};
let pendingElementsInterval;
const elementReadyBatchedFrequency = 100; // ms
/**
* Wait for an element to be ready using a querySelector
*
* @param selector {string}
* @param containerEl {Element} optional container element to search within
* @returns {Promise<Element>}
*/
async function elementReadyBatched(selector, containerEl = document){
let el = document.querySelector(selector);
if (el) {
return el;
}
// group outstanding requests
if (pendingElements[selector]) {
const [promise, _] = pendingElements[selector];
delete pendingElements[selector];
return promise;
}
let resolve;
const promise = new Promise(r => resolve = r);
pendingElements[selector] = [promise, resolve];
if (!pendingElementsInterval) {
pendingElementsInterval = setInterval(() => {
for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) {
const el = containerEl.querySelector(_selector);
if (el) {
_resolve(el);
delete pendingElements[_selector];
}
}
if (!Object.keys(pendingElements).length) {
clearInterval(pendingElementsInterval);
pendingElementsInterval = null;
}
}, elementReadyBatchedFrequency);
}
return pendingElements[selector][0];
}
edit: yes, I know this is very late in coming. Still <3 you.
Thanks @jwilson8767 for the last script,
it did work for me. also i m not sure about if it s more efficient than using mutationobserver..
Crazy hard to understand this script though, quite complicate.
i personaly removed the async and did a return Promise.resolve(el); for the first return.
also added a settimeout to test if the script run more than 4second to stop it in case it didnt find all matches.
@bezborodow Regarding performance issues,
elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:// dict of {selector: [promise, resolve]} const pendingElements = {}; let pendingElementsInterval; const elementReadyBatchedFrequency = 100; // ms /** * Wait for an element to be ready using a querySelector * * @param selector {string} * @param containerEl {Element} optional container element to search within * @returns {Promise<Element>} */ async function elementReadyBatched(selector, containerEl = document){ let el = document.querySelector(selector); if (el) { return el; } // group outstanding requests if (pendingElements[selector]) { const [promise, _] = pendingElements[selector]; delete pendingElements[selector]; return promise; } let resolve; const promise = new Promise(r => resolve = r); pendingElements[selector] = [promise, resolve]; if (!pendingElementsInterval) { pendingElementsInterval = setInterval(() => { for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) { const el = containerEl.querySelector(_selector); if (el) { _resolve(el); delete pendingElements[_selector]; } } if (!Object.keys(pendingElements).length) { clearInterval(pendingElementsInterval); pendingElementsInterval = null; } }, elementReadyBatchedFrequency); } return pendingElements[selector][0]; }edit: yes, I know this is very late in coming. Still <3 you.
Thanks @jwilson8767 for the last script,
it did work for me. also i m not sure about if it s more efficient than using mutationobserver..
Crazy hard to understand this script though, quite complicate.
i personaly removed the async and did a return Promise.resolve(el); for the first return.
also added a settimeout to test if the script run more than 4second to stop it in case it didnt find all matches.
@bezborodow Regarding performance issues,
elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:// dict of {selector: [promise, resolve]} const pendingElements = {}; let pendingElementsInterval; const elementReadyBatchedFrequency = 100; // ms /** * Wait for an element to be ready using a querySelector * * @param selector {string} * @param containerEl {Element} optional container element to search within * @returns {Promise<Element>} */ async function elementReadyBatched(selector, containerEl = document){ let el = document.querySelector(selector); if (el) { return el; } // group outstanding requests if (pendingElements[selector]) { const [promise, _] = pendingElements[selector]; delete pendingElements[selector]; return promise; } let resolve; const promise = new Promise(r => resolve = r); pendingElements[selector] = [promise, resolve]; if (!pendingElementsInterval) { pendingElementsInterval = setInterval(() => { for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) { const el = containerEl.querySelector(_selector); if (el) { _resolve(el); delete pendingElements[_selector]; } } if (!Object.keys(pendingElements).length) { clearInterval(pendingElementsInterval); pendingElementsInterval = null; } }, elementReadyBatchedFrequency); } return pendingElements[selector][0]; }edit: yes, I know this is very late in coming. Still <3 you.
Thanks @jwilson8767 for the last script,
it did work for me. also i m not sure about if it s more efficient than using mutationobserver..
Crazy hard to understand this script though, quite complicate.
i personaly removed the async and did a return Promise.resolve(el); for the first return.
also added a settimeout to test if the script run more than 4second to stop it in case it didnt find all matches.
@bezborodow Regarding performance issues,
elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:// dict of {selector: [promise, resolve]} const pendingElements = {}; let pendingElementsInterval; const elementReadyBatchedFrequency = 100; // ms /** * Wait for an element to be ready using a querySelector * * @param selector {string} * @param containerEl {Element} optional container element to search within * @returns {Promise<Element>} */ async function elementReadyBatched(selector, containerEl = document){ let el = document.querySelector(selector); if (el) { return el; } // group outstanding requests if (pendingElements[selector]) { const [promise, _] = pendingElements[selector]; delete pendingElements[selector]; return promise; } let resolve; const promise = new Promise(r => resolve = r); pendingElements[selector] = [promise, resolve]; if (!pendingElementsInterval) { pendingElementsInterval = setInterval(() => { for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) { const el = containerEl.querySelector(_selector); if (el) { _resolve(el); delete pendingElements[_selector]; } } if (!Object.keys(pendingElements).length) { clearInterval(pendingElementsInterval); pendingElementsInterval = null; } }, elementReadyBatchedFrequency); } return pendingElements[selector][0]; }edit: yes, I know this is very late in coming. Still <3 you.
Thanks @jwilson8767 for the last script,
it did work for me. also i m not sure about if it s more efficient than using mutationobserver..
Crazy hard to understand this script though, quite complicate.
i personaly removed the async and did a return Promise.resolve(el); for the first return.
also added a settimeout to test if the script run more than 4second to stop it in case it didnt find all matches.
@bezborodow Regarding performance issues,
elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:// dict of {selector: [promise, resolve]} const pendingElements = {}; let pendingElementsInterval; const elementReadyBatchedFrequency = 100; // ms /** * Wait for an element to be ready using a querySelector * * @param selector {string} * @param containerEl {Element} optional container element to search within * @returns {Promise<Element>} */ async function elementReadyBatched(selector, containerEl = document){ let el = document.querySelector(selector); if (el) { return el; } // group outstanding requests if (pendingElements[selector]) { const [promise, _] = pendingElements[selector]; delete pendingElements[selector]; return promise; } let resolve; const promise = new Promise(r => resolve = r); pendingElements[selector] = [promise, resolve]; if (!pendingElementsInterval) { pendingElementsInterval = setInterval(() => { for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) { const el = containerEl.querySelector(_selector); if (el) { _resolve(el); delete pendingElements[_selector]; } } if (!Object.keys(pendingElements).length) { clearInterval(pendingElementsInterval); pendingElementsInterval = null; } }, elementReadyBatchedFrequency); } return pendingElements[selector][0]; }edit: yes, I know this is very late in coming. Still <3 you.
Thanks @jwilson8767 for the last script,
it did work for me. also i m not sure about if it s more efficient than using mutationobserver..
Crazy hard to understand this script though, quite complicate.
i personaly removed the async and did a return Promise.resolve(el); for the first return.
also added a settimeout to test if the script run more than 4second to stop it in case it didnt find all matches.
@bezborodow Regarding performance issues,
elementReady()
should definitely be taken as a convenience function, I still use it occasionally but only where it is expected to run only a few times in the lifecycle of a page (such as to detect when a component's root element has been added to the page). MutationObservers as a whole aren't amazing performance-wise, really. For much better performance (while still working on arbitrary selectors), I'd actually recommend using a sort of long-polling strategy via setInterval. You could either create one setInterval per selector, or a shared setInterval and an array of outstanding selectors to match against. Here's an example of the latter:// dict of {selector: [promise, resolve]} const pendingElements = {}; let pendingElementsInterval; const elementReadyBatchedFrequency = 100; // ms /** * Wait for an element to be ready using a querySelector * * @param selector {string} * @param containerEl {Element} optional container element to search within * @returns {Promise<Element>} */ async function elementReadyBatched(selector, containerEl = document){ let el = document.querySelector(selector); if (el) { return el; } // group outstanding requests if (pendingElements[selector]) { const [promise, _] = pendingElements[selector]; delete pendingElements[selector]; return promise; } let resolve; const promise = new Promise(r => resolve = r); pendingElements[selector] = [promise, resolve]; if (!pendingElementsInterval) { pendingElementsInterval = setInterval(() => { for (const [_selector, [_, _resolve]] of Object.entries(pendingElements)) { const el = containerEl.querySelector(_selector); if (el) { _resolve(el); delete pendingElements[_selector]; } } if (!Object.keys(pendingElements).length) { clearInterval(pendingElementsInterval); pendingElementsInterval = null; } }, elementReadyBatchedFrequency); } return pendingElements[selector][0]; }edit: yes, I know this is very late in coming. Still <3 you.
@LouisDeconinck It should be as simple as: